Change in coreboot[master]: mb/google/hatch/dratini: Describe the privacy_gpio

List overview All Threads
Download

newer

older

Change in coreboot[master]: Revert...

Ricardo Ribalda (Code Review)

9 Nov 2020 9 Nov '20

12:57 p.m.

Ricardo Ribalda has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47362 )

Change subject: mb/google/hatch/dratini: Describe the privacy_gpio ......................................................................

mb/google/hatch/dratini: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and gpio.

BUG=b:172807539

Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Signed-off-by: Ricardo Ribalda ribalda@chromium.org --- M src/mainboard/google/hatch/variants/dratini/gpio.c M src/mainboard/google/hatch/variants/dratini/overridetree.cb 2 files changed, 15 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/47362/1

diff --git a/src/mainboard/google/hatch/variants/dratini/gpio.c b/src/mainboard/google/hatch/variants/dratini/gpio.c index ccb5c05..f50f8f2 100644 --- a/src/mainboard/google/hatch/variants/dratini/gpio.c +++ b/src/mainboard/google/hatch/variants/dratini/gpio.c @@ -16,6 +16,8 @@ PAD_NC(GPP_A19, NONE), /* C12 : FPMCU_PCH_BOOT1 */ PAD_CFG_GPO(GPP_C12, 0, DEEP), + /* D4 : Camera Privacy Status */ + PAD_CFG_GPI_INT(GPP_D4, NONE, PLTRST, EDGE_BOTH), /* F1 : NC */ PAD_NC(GPP_F1, NONE), /* F3 : MEM_STRAP_3 */ diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index c5e2aeb..98beaaa 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -69,6 +69,19 @@ register "ScsEmmcHs400Enabled" = "1"

device domain 0 on + device pci 14.0 on + chip drivers/usb/acpi + device usb 0.0 on + chip drivers/usb/acpi + # The Linux Kernel does not allow an inverted BOTH_EDGE irq + # So we need to use GpioIO() instead of GpioInt() + # https://www.kernel.org/doc/Documentation/acpi/gpio-properties.txt + register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D4)" + device usb 2.6 on end + end + end + end + end # USB xHCI device pci 15.0 on chip drivers/i2c/generic register "hid" = ""ELAN0000""

Attachments:

attachment.htm (text/html — 4.4 KB)

Show replies by date

Furquan Shaikh (Code Review)

9 Nov 9 Nov

7:55 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47362 )

Change subject: mb/google/hatch/dratini: Describe the privacy_gpio ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/47362/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47362/1/src/mainboard/google/hatch/... PS1, Line 72: nit: tabs instead of spaces.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Gerrit-Change-Number: 47362 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 09 Nov 2020 19:55:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

8:32 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47362

to look at the new patch set (#2).

Change subject: mb/google/hatch/dratini: Describe the privacy_gpio ......................................................................

mb/google/hatch/dratini: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and gpio.

BUG=b:172807539

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/47362/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Gerrit-Change-Number: 47362 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

8:33 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47362 )

Change subject: mb/google/hatch/dratini: Describe the privacy_gpio ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Gerrit-Change-Number: 47362 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 09 Nov 2020 20:33:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

8:33 p.m.

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47362 )

Change subject: mb/google/hatch/dratini: Describe the privacy_gpio ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47362/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47362/1/src/mainboard/google/hatch/... PS1, Line 72:

...

nit: tabs instead of spaces.

Ups

Sorry about that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Gerrit-Change-Number: 47362 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 09 Nov 2020 20:33:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:34 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47362 )

Change subject: mb/google/hatch/dratini: Describe the privacy_gpio ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47362/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47362/2//COMMIT_MSG@12 PS2, Line 12: You probably need to cherry-pick this to hatch firmware branch if you want to roll the change out to the device. You can sync up with Shelley on getting this in.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Gerrit-Change-Number: 47362 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 09 Nov 2020 20:34:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

8:37 p.m.

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47362 )

Change subject: mb/google/hatch/dratini: Describe the privacy_gpio ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47362/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47362/2//COMMIT_MSG@12 PS2, Line 12:

...

You probably need to cherry-pick this to hatch firmware branch if you want to roll the change out to […]

Thanks, once the kernel part has also landed I will ping her.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Gerrit-Change-Number: 47362 Gerrit-PatchSet: 2 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 09 Nov 2020 20:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

16 Nov 16 Nov

11:07 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47362 )

Change subject: mb/google/hatch/dratini: Describe the privacy_gpio ......................................................................

mb/google/hatch/dratini: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and gpio.

BUG=b:172807539

Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Signed-off-by: Ricardo Ribalda ribalda@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/47362 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/dratini/gpio.c M src/mainboard/google/hatch/variants/dratini/overridetree.cb 2 files changed, 15 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/dratini/gpio.c b/src/mainboard/google/hatch/variants/dratini/gpio.c index ccb5c05..f50f8f2 100644 --- a/src/mainboard/google/hatch/variants/dratini/gpio.c +++ b/src/mainboard/google/hatch/variants/dratini/gpio.c @@ -16,6 +16,8 @@ PAD_NC(GPP_A19, NONE), /* C12 : FPMCU_PCH_BOOT1 */ PAD_CFG_GPO(GPP_C12, 0, DEEP), + /* D4 : Camera Privacy Status */ + PAD_CFG_GPI_INT(GPP_D4, NONE, PLTRST, EDGE_BOTH), /* F1 : NC */ PAD_NC(GPP_F1, NONE), /* F3 : MEM_STRAP_3 */ diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 6ec1a48..3b094a3 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -69,6 +69,19 @@ register "ScsEmmcHs400Enabled" = "1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/47362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Gerrit-Change-Number: 47362 Gerrit-PatchSet: 3 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Ricardo Ribalda (Code Review)

28 Jan 28 Jan

1:17 p.m.

Ricardo Ribalda has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/47362 )

Change subject: mb/google/hatch/dratini: Describe the privacy_gpio ......................................................................

-- To view, visit https://review.coreboot.org/c/coreboot/+/47362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1bfa63e35a16d71a26adc3ec07b1ba36e6dc168 Gerrit-Change-Number: 47362 Gerrit-PatchSet: 3 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: revert

1402

days inactive

1482

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Ricardo Ribalda (Code Review)