Attention is currently required from: Jamie Ryu, Saurabh Mishra.
Subrata Banik has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/83784?usp=email )
Change subject: soc/intel/cmn/pmc: Add API to dump silicon QDF information
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
why this CL is part of the PTL SoC code recipe ?
I don't see a need to do that. You are just adding a new API. And if any PTL code would like to use this API that can be done as part of PTL SoC recipe code later (and nothing needs to be addressed now itself while prep for PTL SoC code)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83784?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I927da1a97e6dad4ee54c4d2256fea5813a0ce43d
Gerrit-Change-Number: 83784
Gerrit-PatchSet: 11
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Comment-Date: Thu, 08 Aug 2024 06:16:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No