Change in coreboot[master]: soc/amd/picasso/config: add comment about cfg never being NULL

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48354 )

Change subject: soc/amd/picasso/config: add comment about cfg never being NULL
......................................................................

soc/amd/picasso/config: add comment about cfg never being NULL

Change-Id: I39cf2d28749536cb7d9462fa4af412850677f2e3
Signed-off-by: Felix Held 
---
M src/soc/amd/picasso/config.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/48354/1

diff --git a/src/soc/amd/picasso/config.c b/src/soc/amd/picasso/config.c
index 3d4bc7b..577d7b2 100644
--- a/src/soc/amd/picasso/config.c
+++ b/src/soc/amd/picasso/config.c
@@ -6,6 +6,7 @@

const struct soc_amd_common_config *soc_get_common_config()
 {
+	/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
    const struct soc_amd_picasso_config *cfg = config_of_soc();
    return &cfg->common_config;
 }

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48354 )

Change subject: soc/amd/picasso/config: add comment about cfg never being NULL
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48354 )

Change subject: soc/amd/picasso/config: add comment about cfg never being NULL
......................................................................

soc/amd/picasso/config: add comment about cfg never being NULL

Change-Id: I39cf2d28749536cb7d9462fa4af412850677f2e3
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48354
Tested-by: build bot (Jenkins) 
Reviewed-by: Marshall Dawson 
---
M src/soc/amd/picasso/config.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marshall Dawson: Looks good to me, approved

diff --git a/src/soc/amd/picasso/config.c b/src/soc/amd/picasso/config.c
index 3d4bc7b..577d7b2 100644
--- a/src/soc/amd/picasso/config.c
+++ b/src/soc/amd/picasso/config.c
@@ -6,6 +6,7 @@

const struct soc_amd_common_config *soc_get_common_config()
 {
+	/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
    const struct soc_amd_picasso_config *cfg = config_of_soc();
    return &cfg->common_config;
 }