build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )
Change subject: cpu/qemu-x86: Add x86_64 bootblock support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35680/2/util/pgtblgen/pgtblgen.c File util/pgtblgen/pgtblgen.c:
https://review.coreboot.org/c/coreboot/+/35680/2/util/pgtblgen/pgtblgen.c@33 PS2, Line 33: printf("usage: %s -b <addr> -a <arch> -o <file>\n", argv[0]); Prefer using '"%s...", __func__' to using 'usage', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/35680/2/util/pgtblgen/pgtblgen.c@13... PS2, Line 139: FILE *fd = fopen(filename, "wb"); need consistent spacing around '*' (ctx:WxV)