Attention is currently required from: Hung-Te Lin, Martin Roth - Personal, Edward O'Callaghan, Julius Werner.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60236 )
Change subject: util/futility: Ensure futility checks for flashrom as a dep
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Despite the discussion of the default behaviour, two general questions:
1. Will it be more reasonable if we check-flashrom-presence then if support, USE_LIBFLASHROM=1 else 0?
IMO always passing USE_LIBFLASHROM=0 is reasonable, but I would like to raise this question to see if it worth discussing.
2. We should also pass USD_LIBFLASHROM=0 in util/cbfstool/Makefile
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d
Gerrit-Change-Number: 60236
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth - Personal
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Martin Roth - Personal
martinroth@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 24 Dec 2021 02:33:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment