Attention is currently required from: Hung-Te Lin, KuanHsun Cheng, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71754 )
Change subject: soc/mediatek/common: Reset the watchdog timer before triggering reset
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71754/comment/c7c3d773_41584040
PS2, Line 13: Also, add
: a 100 us delay before triggering the reset signal.
Also, because WDT hardware needs about 94us to synchronize the registers, add a 100us delay before triggering the reset signal.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71754
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4964103d54910c4a1e675b59c362e93c2213b19
Gerrit-Change-Number: 71754
Gerrit-PatchSet: 2
Gerrit-Owner: KuanHsun Cheng
Allen-KH.Cheng@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Allen-KH Cheng
allen-kh.cheng@mediatek.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: KuanHsun Cheng
Allen-KH.Cheng@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Mon, 09 Jan 2023 06:22:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment