Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19661 )
Change subject: arch/arm64: Use variables of the right size for msr/mrs opcodes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19661/1/src/arch/arm64/armv8/lib/clock.c File src/arch/arm64/armv8/lib/clock.c:
PS1, Line 24: uint32_t
Clang appears to be right, why not use use(uint64_t freq)? it seems cleaner
it's merely a difference in interpretation: gcc does implicit casts in asm input/output specifications, clang does not.
As for using uint64_t, that would be wrong: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0488d/ch09s03... specifies cntfrq_el0 to be 32 bit wide.