Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49260 )
Change subject: mb/intel/adlrvp: Update GPIOs as per latest schematics
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49260/comment/2e6ff6e9_a701bf01
PS1, Line 10: :
nit: for ranges, I would use `.. […]
Ack
File src/mainboard/intel/adlrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/49260/comment/411ec310_9068ca4b
PS1, Line 249: PAD_NC(GPP_H23, NONE),
Out of curiosity, why is this one moved?
my bad, 😭
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49260
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedb1f8fbf5f96a9617b72ba1a6419e3fd4e331b4
Gerrit-Change-Number: 49260
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 09 Jan 2021 15:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment