Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Paul Menzel, Tim Van Patten.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email )
Change subject: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76091/comment/1a80476a_bca7aaf4 :
PS2, Line 9: FT6
: Infrastructure Roadmap"#57316
Is there an AMD bug to update the documentation for future SOCs?
https://partnerissuetracker.corp.google.com/issues/288545213
https://review.coreboot.org/c/coreboot/+/76091/comment/1bbcf075_3a8d3f92 :
PS2, Line 12: Both SMU and FSP interpret configs > 3 as 3.
There is a point early in the flow, where the FSP also does not know anything about the expected TDP […]
Done
https://review.coreboot.org/c/coreboot/+/76091/comment/c58da38f_69271c19 :
PS2, Line 15: TEST=Confirm extra message is not sent in serial log.
In the source for pmfw, 3 was always used, the 4 was just replaced by 3 because it was >3.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76091?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626
Gerrit-Change-Number: 76091
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Fri, 23 Jun 2023 18:48:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jason Glenesk
jason.glenesk@gmail.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment