Change in coreboot[master]: mb/google/dedede: Adding spd hex file for Samsung memory part

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Change in coreboot[master]:...

Meera Ravindranath (Code Review)

6 Mar 2020 6 Mar '20

10:12 a.m.

Meera Ravindranath has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39348 )

Change subject: mb/google/dedede: Adding spd hex file for Samsung memory part ......................................................................

mb/google/dedede: Adding spd hex file for Samsung memory part

BUG=b:150154457 BRANCH=none TEST=Build dedede, flash and boot to kernel.

Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- A src/mainboard/google/dedede/spd/samsung-K4U6E3S4AA-MGCL.spd.hex M src/mainboard/google/dedede/variants/waddledoo/Makefile.inc 2 files changed, 33 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/39348/1

diff --git a/src/mainboard/google/dedede/spd/samsung-K4U6E3S4AA-MGCL.spd.hex b/src/mainboard/google/dedede/spd/samsung-K4U6E3S4AA-MGCL.spd.hex new file mode 100644 index 0000000..e1f27fb --- /dev/null +++ b/src/mainboard/google/dedede/spd/samsung-K4U6E3S4AA-MGCL.spd.hex @@ -0,0 +1,32 @@ +23 11 11 0E 15 19 95 08 00 40 00 00 02 21 00 00 +48 00 04 FF 92 55 00 00 8C 00 90 A8 90 C0 08 60 +04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 7F E1 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 20 00 00 00 20 20 20 20 20 20 20 +20 20 20 20 20 20 20 20 20 20 20 20 20 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/dedede/variants/waddledoo/Makefile.inc b/src/mainboard/google/dedede/variants/waddledoo/Makefile.inc index 28da8f6..c55051b 100644 --- a/src/mainboard/google/dedede/variants/waddledoo/Makefile.inc +++ b/src/mainboard/google/dedede/variants/waddledoo/Makefile.inc @@ -8,3 +8,4 @@

SPD_SOURCES = empty #0b0000 SPD_SOURCES += Micron_MT53E512M32D2NP_2GB #0b0001 +SPD_SOURCES += samsung-K4U6E3S4AA-MGCL #0b0010

Attachments:

attachment.htm (text/html — 6.0 KB)

Show replies by thread

Paul Menzel (Code Review)

6 Mar 6 Mar

1:19 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39348 )

Change subject: mb/google/dedede: Adding spd hex file for Samsung memory part ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39348/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39348/1//COMMIT_MSG@7 PS1, Line 7: spd hex SPD

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 1 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 06 Mar 2020 12:19:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Meera Ravindranath (Code Review)

9 Mar 9 Mar

5:24 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Adding SPD hex file for Samsung memory part

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Aamir Bohra, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39348

to look at the new patch set (#2).

Change subject: mb/google/dedede: Adding SPD hex file for Samsung memory part ......................................................................

mb/google/dedede: Adding SPD hex file for Samsung memory part

BUG=b:150154457 BRANCH=none TEST=Build dedede, flash and boot to kernel.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/39348/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 2 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Meera Ravindranath (Code Review)

5:24 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Adding SPD hex file for Samsung memory part

Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39348 )

Change subject: mb/google/dedede: Adding SPD hex file for Samsung memory part ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39348/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39348/1//COMMIT_MSG@7 PS1, Line 7: spd hex

...

SPD

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 2 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Mar 2020 04:24:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Aamir Bohra (Code Review)

6:11 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Adding SPD hex file for Samsung memory part

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39348 )

Change subject: mb/google/dedede: Adding SPD hex file for Samsung memory part ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 2 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Mar 2020 05:11:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

2:14 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Adding SPD hex file for Samsung memory part

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39348 )

Change subject: mb/google/dedede: Adding SPD hex file for Samsung memory part ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39348/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39348/2//COMMIT_MSG@7 PS2, Line 7: Adding Imperative mood: Add

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 2 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Mar 2020 13:14:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Meera Ravindranath (Code Review)

11 Mar 11 Mar

7:33 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Add SPD hex file for Samsung memory part

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Aamir Bohra, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39348

to look at the new patch set (#3).

Change subject: mb/google/dedede: Add SPD hex file for Samsung memory part ......................................................................

mb/google/dedede: Add SPD hex file for Samsung memory part

BUG=b:150154457 BRANCH=none TEST=Build dedede, flash and boot to kernel.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/39348/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Meera Ravindranath (Code Review)

7:34 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Add SPD hex file for Samsung memory part

Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39348 )

Change subject: mb/google/dedede: Add SPD hex file for Samsung memory part ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39348/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39348/2//COMMIT_MSG@7 PS2, Line 7: Adding

...

Imperative mood: Add

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 06:34:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

4:10 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Add SPD hex file for Samsung memory part

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39348 )

Change subject: mb/google/dedede: Add SPD hex file for Samsung memory part ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 15:10:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:12 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Add SPD hex file for Samsung memory part

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39348 )

Change subject: mb/google/dedede: Add SPD hex file for Samsung memory part ......................................................................

mb/google/dedede: Add SPD hex file for Samsung memory part

BUG=b:150154457 BRANCH=none TEST=Build dedede, flash and boot to kernel.

Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39348 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Aamir Bohra aamir.bohra@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/mainboard/google/dedede/spd/samsung-K4U6E3S4AA-MGCL.spd.hex M src/mainboard/google/dedede/variants/waddledoo/Makefile.inc 2 files changed, 33 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Aamir Bohra: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved

SPD_SOURCES = empty #0b0000 SPD_SOURCES += Micron_MT53E512M32D2NP_2GB #0b0001 +SPD_SOURCES += samsung-K4U6E3S4AA-MGCL #0b0010

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 4 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

4:22 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Add SPD hex file for Samsung memory part

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39348 )

Change subject: mb/google/dedede: Add SPD hex file for Samsung memory part ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1262 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1261 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1260

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/39348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7248861efd1edd5a0df0e17d39a47c168cab100e Gerrit-Change-Number: 39348 Gerrit-PatchSet: 4 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 15:22:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1519

days inactive

1524

days old

coreboot-gerrit@coreboot.org

10 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Aamir Bohra (Code Review)
Karthik Ramasubramanian (Code Review)
Meera Ravindranath (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)