Attention is currently required from: Hung-Te Lin, Kei Hiroyoshi.
Paul Menzel has posted comments on this change by Kei Hiroyoshi. ( https://review.coreboot.org/c/coreboot/+/80136?usp=email )
Change subject: mb/google/corsola: Add new board 'Kyogre'
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80136/comment/c619289d_16fdb18d?usp... :
PS1, Line 7: Add new board 'Kyogre'
Please look at other commits, how to add it. I think, this one should be named *variant*.
File src/mainboard/google/corsola/Kconfig:
https://review.coreboot.org/c/coreboot/+/80136/comment/faa9916c_5fb8c464?usp... :
PS1, Line 13: BOARD_GOOGLE_KYOGRE
Please sort it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80136?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic84b9ddb5ac24b468b5c3aa5328b89960bbf389c
Gerrit-Change-Number: 80136
Gerrit-PatchSet: 1
Gerrit-Owner: Kei Hiroyoshi
hiroyoshi.kei@fujitsu.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Kei Hiroyoshi
hiroyoshi.kei@fujitsu.corp-partner.google.com
Gerrit-Comment-Date: Fri, 26 Jul 2024 05:56:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No