Attention is currently required from: ChiaLing, Paul Menzel, Ryan Lin, Subrata Banik, Sumeet R Pawnikar, Zhuohao Lee.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75679?usp=email )
Change subject: soc/intel/jasperlake: Add per-SKU power limits
......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75679/comment/726d130d_8279aa5c :
PS10, Line 171:
remove one tab (and same for all the overridetrees)
File src/mainboard/google/dedede/variants/dibbi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75679/comment/83e50238_1d92c023 :
PS10, Line 29: register "power_limits_config[JSL_N4500_6W_CORE]" = "{
This overrides the whole struct, so you need to set PL1 and PL2 as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75679?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic086e32a2692f4f5f9b661585b216fa207fc56fd
Gerrit-Change-Number: 75679
Gerrit-PatchSet: 10
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: ChiaLing
chia-ling.hou@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 23:38:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment