Attention is currently required from: Ravi kumar, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61342 )
Change subject: qualcomm/sc7280: Add support for edp and mdp driver
......................................................................
Patch Set 13:
(1 comment)
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
https://review.coreboot.org/c/coreboot/+/61342/comment/9a9dd9d4_09e3bdc2
PS13, Line 360: gpio_output(GPIO(80), 1);
: mdelay(20);
: gpio_configure(GPIO(60), GPIO_FUNC_GPIO,
: GPIO_PULL_DOWN, GPIO_2MA, GPIO_INPUT);
: mdelay(10);
: gpio_output(GPIO(8), 1);
: mdelay(20);
any chance that we can clarify what these GPIOs are? Either #define them or at least add comments to what these 3 GPIOs are.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61342
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If89abb76028766b19450e756889a5d7776106f95
Gerrit-Change-Number: 61342
Gerrit-PatchSet: 13
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 17 Mar 2022 23:45:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment