Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68487 )
Change subject: soc/mediatek/mt8188: Add ddp driver to support eDP output ......................................................................
soc/mediatek/mt8188: Add ddp driver to support eDP output
Add DDP (display data path) driver that supports overlay, read/write DMA, etc. The output goes to display interface DP_INTF0 directly. Add ddp gclast and output_clamp settings to MT8188 to support multi-layer display.
BUG=b:244208960 TEST=emerge-geralt coreboot.
Signed-off-by: Nathan Lu nathan.lu@mediatek.com Change-Id: Icc0a878c609818fedd298c141bb39469fd2f6388 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68487 Reviewed-by: Yu-Ping Wu yupingso@google.com Reviewed-by: Yidi Lin yidilin@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8188/Makefile.inc A src/soc/mediatek/mt8188/ddp.c M src/soc/mediatek/mt8188/include/soc/addressmap.h A src/soc/mediatek/mt8188/include/soc/ddp.h 4 files changed, 483 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, but someone else must approve
diff --git a/src/soc/mediatek/mt8188/Makefile.inc b/src/soc/mediatek/mt8188/Makefile.inc index d446d5a..63c7f4a 100644 --- a/src/soc/mediatek/mt8188/Makefile.inc +++ b/src/soc/mediatek/mt8188/Makefile.inc @@ -30,6 +30,7 @@
ramstage-y += ../common/auxadc.c ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += ../common/bl31.c +ramstage-y += ../common/ddp.c ddp.c ramstage-y += ../common/devapc.c devapc.c ramstage-y += ../common/dfd.c ramstage-y += ../common/dpm.c diff --git a/src/soc/mediatek/mt8188/ddp.c b/src/soc/mediatek/mt8188/ddp.c new file mode 100644 index 0000000..8d2d43a --- /dev/null +++ b/src/soc/mediatek/mt8188/ddp.c @@ -0,0 +1,162 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ + +#include <console/console.h> +#include <device/mmio.h> +#include <edid.h> +#include <soc/addressmap.h> +#include <soc/ddp.h> + +static void disp_config_main_path_connection(void) +{ + /* ovl0 */ + write32(&mmsys_cfg->mmsys_ovl_mout_en, + DISP_OVL0_TO_DISP_RDMA0); + write32(&mmsys_cfg->mmsys_dp_intf0_sel_in, + SEL_IN_DP_INTF0_FROM_DISP_DITHER0); + write32(&mmsys_cfg->mmsys_dither0_sel_out, + SEL_OUT_DISP_DITHER0_TO_DP_INTF0); +} + +static void disp_config_main_path_mutex(void) +{ + write32(&disp_mutex->mutex[0].mod, MUTEX_MOD_MAIN_PATH); + + /* Clock source from DP_INTF0 */ + write32(&disp_mutex->mutex[0].ctl, + MUTEX_SOF_DP_INTF0 | (MUTEX_SOF_DP_INTF0 << 7)); + write32(&disp_mutex->mutex[0].en, BIT(0)); +} + +static void ovl_layer_smi_id_en(u32 idx) +{ + setbits32(&disp_ovl[idx]->datapath_con, BIT(0)); +} + +static void ovl_layer_gclast_en(u32 idx) +{ + setbits32(&disp_ovl[idx]->datapath_con, BIT(24)); + setbits32(&disp_ovl[idx]->datapath_con, BIT(25)); +} + +static void ovl_layer_output_clamp_en(u32 idx) +{ + setbits32(&disp_ovl[idx]->datapath_con, BIT(26)); +} + +static void ovl_layer_en(u32 idx) +{ + setbits32(&disp_ovl[idx]->en, BIT(0)); +} + +static void ccorr_config(u32 width, u32 height) +{ + struct disp_ccorr_regs *const regs = disp_ccorr; + + write32(®s->size, width << 16 | height); + clrsetbits32(®s->cfg, PQ_ENGINE_EN, PQ_RELAY_MODE); + write32(®s->en, PQ_EN); +} + +static void aal_config(u32 width, u32 height) +{ + struct disp_aal_regs *const regs = disp_aal; + + write32(®s->size, width << 16 | height); + write32(®s->output_size, width << 16 | height); + clrsetbits32(®s->cfg, PQ_ENGINE_EN, PQ_RELAY_MODE); + write32(®s->en, PQ_EN); +} + +static void gamma_config(u32 width, u32 height) +{ + struct disp_gamma_regs *const regs = disp_gamma; + + write32(®s->size, width << 16 | height); + setbits32(®s->cfg, PQ_RELAY_MODE); + write32(®s->en, PQ_EN); +} + +static void postmask_config(u32 width, u32 height) +{ + struct disp_postmask_regs *const regs = disp_postmask; + + write32(®s->size, width << 16 | height); + setbits32(®s->cfg, PQ_RELAY_MODE); + write32(®s->en, PQ_EN); +} + +static void dither_config(u32 width, u32 height) +{ + struct disp_dither_regs *const regs = disp_dither; + + write32(®s->size, width << 16 | height); + setbits32(®s->cfg, PQ_RELAY_MODE); + write32(®s->en, PQ_EN); +} + +static void main_disp_path_setup(u32 width, u32 height, u32 vrefresh) +{ + u32 idx; + const u32 pixel_clk = width * height * vrefresh; + + for (idx = 0; idx < MAIN_PATH_OVL_NR; idx++) { + ovl_set_roi(idx, width, height, idx ? 0 : 0xff0000ff); + ovl_layer_smi_id_en(idx); + ovl_layer_gclast_en(idx); + ovl_layer_output_clamp_en(idx); + ovl_layer_en(idx); + } + + rdma_config(width, height, pixel_clk, 5 * KiB); + color_start(width, height); + ccorr_config(width, height); + aal_config(width, height); + gamma_config(width, height); + postmask_config(width, height); + dither_config(width, height); + disp_config_main_path_connection(); + disp_config_main_path_mutex(); +} + +static void disp_clock_on(void) +{ + clrbits32(&mmsys_cfg->mmsys_cg_con0, CG_CON0_DISP_ALL); + clrbits32(&mmsys_cfg->mmsys_cg_con1, CG_CON1_DISP_ALL); + clrbits32(&mmsys_cfg->mmsys_cg_con2, CG_CON2_DISP_ALL); +} + +void mtk_ddp_init(void) +{ + disp_clock_on(); + + /* Turn off M4U port. */ + write32p(SMI_LARB0 + SMI_LARB_PORT_L0_OVL_RDMA0, 0); +} + +void mtk_ddp_mode_set(const struct edid *edid) +{ + u32 fmt = OVL_INFMT_RGBA8888; + u32 bpp = edid->framebuffer_bits_per_pixel / 8; + u32 width = edid->mode.ha; + u32 height = edid->mode.va; + u32 vrefresh = edid->mode.refresh; + + printk(BIOS_DEBUG, "%s: display resolution: %dx%d@%d bpp %d\n", + __func__, width, height, vrefresh, bpp); + + if (!vrefresh) { + if (!width || !height) + vrefresh = 60; + else + vrefresh = edid->mode.pixel_clock * 1000 / + ((width + edid->mode.hbl) * + (height + edid->mode.vbl)); + + printk(BIOS_WARNING, "%s: vrefresh is not provided; using %d\n", + __func__, vrefresh); + } + + main_disp_path_setup(width, height, vrefresh); + rdma_start(); + ovl_layer_config(fmt, bpp, width, height); +} diff --git a/src/soc/mediatek/mt8188/include/soc/addressmap.h b/src/soc/mediatek/mt8188/include/soc/addressmap.h index 55a1497..904e77e 100644 --- a/src/soc/mediatek/mt8188/include/soc/addressmap.h +++ b/src/soc/mediatek/mt8188/include/soc/addressmap.h @@ -88,5 +88,17 @@ I2C6_BASE = IO_PHYS + 0x01EC1000, EFUSE_BASE = IO_PHYS + 0x01F20000, MSDC0_TOP_BASE = IO_PHYS + 0x01F50000, + DISP_OVL0_BASE = IO_PHYS + 0x0C000000, + DISP_RDMA0_BASE = IO_PHYS + 0x0C002000, + DISP_COLOR0_BASE = IO_PHYS + 0x0C003000, + DISP_CCORR0_BASE = IO_PHYS + 0x0C004000, + DISP_AAL0_BASE = IO_PHYS + 0x0C005000, + DISP_GAMMA0_BASE = IO_PHYS + 0x0C006000, + DISP_DITHER0_BASE = IO_PHYS + 0x0C007000, + DISP_OVL1_BASE = IO_PHYS + 0x0C00A000, + DISP_MUTEX_BASE = IO_PHYS + 0x0C016000, + DISP_POSTMASK0_BASE = IO_PHYS + 0x0C01A000, + VDOSYS0_BASE = IO_PHYS + 0x0C01D000, + SMI_LARB0 = IO_PHYS + 0x0C022000, }; #endif diff --git a/src/soc/mediatek/mt8188/include/soc/ddp.h b/src/soc/mediatek/mt8188/include/soc/ddp.h new file mode 100644 index 0000000..26f0151 --- /dev/null +++ b/src/soc/mediatek/mt8188/include/soc/ddp.h @@ -0,0 +1,286 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ + +#ifndef _SOC_MEDIATEK_MT8188_DDP_H_ +#define _SOC_MEDIATEK_MT8188_DDP_H_ + +#include <soc/addressmap.h> +#include <soc/ddp_common.h> +#include <types.h> + +#define MAIN_PATH_OVL_NR 1 + +struct mmsys_cfg_regs { + u32 reserved_0x000[64]; /* 0x000 */ + u32 mmsys_cg_con0; /* 0x100 */ + u32 mmsys_cg_set0; /* 0x104 */ + u32 mmsys_cg_clr0; /* 0x108 */ + u32 reserved_0x10c; /* 0x10C */ + u32 mmsys_cg_con1; /* 0x110 */ + u32 mmsys_cg_set1; /* 0x114 */ + u32 mmsys_cg_clr1; /* 0x118 */ + u32 reserved_0x11c; /* 0x11C */ + u32 mmsys_cg_con2; /* 0x120 */ + u32 mmsys_cg_set2; /* 0x124 */ + u32 mmsys_cg_clr2; /* 0x128 */ + u32 reserved_0x12c[885]; /* 0x12C */ + u32 reserved_0xf00; /* 0xF00 */ + u32 reserved_0xf04; /* 0xF04 */ + u32 reserved_0xf08; /* 0xF08 */ + u32 reserved_0xf0c; /* 0xF0C */ + u32 reserved_0xf10; /* 0xF10 */ + u32 mmsys_ovl_mout_en; /* 0xF14 */ + u32 reserved_0xf18; /* 0xF18 */ + u32 reserved_0xf1c; /* 0xF1C */ + u32 reserved_0xf20; /* 0xF20 */ + u32 reserved_0xf24; /* 0xF24 */ + u32 reserved_0xf28; /* 0xF28 */ + u32 reserved_0xf2c; /* 0xF2C */ + u32 reserved_0xf30; /* 0xF30 */ + u32 mmsys_sel_in; /* 0xF34 */ + u32 mmsys_sel_out; /* 0xF38 */ + u32 reserved_0xf3c; /* 0xF3C */ + u32 reserved_0xf40; /* 0xF40 */ + u32 mmsys_dsi0_sel_in; /* 0xF44 */ + u32 reserved_0xf48; /* 0xF48 */ + u32 mmsys_dp_intf0_sel_in; /* 0xF4C */ + u32 reserved_0xf50; /* 0xF50 */ + u32 reserved_0xf54; /* 0xF54 */ + u32 mmsys_dither0_sel_out; /* 0xF58 */ +}; +check_member(mmsys_cfg_regs, mmsys_cg_con0, 0x100); +check_member(mmsys_cfg_regs, mmsys_cg_con1, 0x110); +check_member(mmsys_cfg_regs, mmsys_cg_con2, 0x120); +check_member(mmsys_cfg_regs, mmsys_ovl_mout_en, 0xF14); + +static struct mmsys_cfg_regs *const mmsys_cfg = (void *)VDOSYS0_BASE; + +/* + * DISP_REG_CONFIG_MMSYS_CG_CON0 + * Configures free-run vdo0_clks gating 0 + * - 0: Enable clock + * - 1: Clock gating + */ +enum { + CG_CON0_DISP_OVL0 = BIT(0), + CG_CON0_DISP_CCORR0 = BIT(4), + CG_CON0_DISP_MUTEX0 = BIT(6), + CG_CON0_DISP_GAMMA0 = BIT(8), + CG_CON0_DISP_DITHER0 = BIT(10), + CG_CON0_DISP_RDMA0 = BIT(19), + CG_CON0_DISP_DSI0 = BIT(21), + CG_CON0_DISP_DSC_WRAP0 = BIT(23), + CG_CON0_DISP_VPP_MERGE0 = BIT(24), + CG_CON0_DISP_DP_INTF0 = BIT(25), + CG_CON0_DISP_AAL0 = BIT(26), + CG_CON0_DISP_COLOR0 = BIT(29), + + CG_CON0_DISP_ALL = CG_CON0_DISP_MUTEX0 | + CG_CON0_DISP_OVL0 | + CG_CON0_DISP_RDMA0 | + CG_CON0_DISP_COLOR0 | + CG_CON0_DISP_CCORR0 | + CG_CON0_DISP_AAL0 | + CG_CON0_DISP_GAMMA0 | + CG_CON0_DISP_DITHER0 | + CG_CON0_DISP_DP_INTF0, + CG_CON0_ALL = 0xffffffff +}; + +/* + * DISP_REG_CONFIG_MMSYS_CG_CON1 + * Configures free-run clock gating 0 + * - 0: Enable clock + * - 1: Clock gating + */ +enum { + CG_CON1_DISP_POSTMASK0 = BIT(0), + CG_CON1_SMI_GALS = BIT(10), + CG_CON1_SMI_COMMON = BIT(11), + CG_CON1_SMI_EMI = BIT(12), + CG_CON1_SMI_IOMMU = BIT(13), + CG_CON1_SMI_LARB = BIT(14), + CG_CON1_SMI_RSI = BIT(15), + + CG_CON1_DISP_ALL = CG_CON1_DISP_POSTMASK0 | + CG_CON1_SMI_GALS | + CG_CON1_SMI_COMMON | + CG_CON1_SMI_EMI | + CG_CON1_SMI_IOMMU | + CG_CON1_SMI_LARB | + CG_CON1_SMI_RSI, + CG_CON1_ALL = 0xffffffff +}; + +/* + * DISP_REG_CONFIG_MMSYS_CG_CON2 + * Configures free-run clock gating 0 + * - 0: Enable clock + * - 1: Clock gating + */ +enum { + CG_CON2_DSI_DSI0 = BIT(0), + CG_CON2_DPI_DPI0 = BIT(8), + CG_CON2_DP_INTF0 = BIT(16), + + CG_CON2_DISP_ALL = CG_CON2_DP_INTF0, + CG_CON2_ALL = 0xffffffff +}; + +enum { + DISP_OVL0_GO_BLEND = BIT(0), + DISP_OVL0_GO_BG = BIT(1), + DISP_OVL0_TO_DISP_RDMA0 = BIT(0), + DITHER0_MOUT_DSI0 = BIT(0), +}; + + +enum { + SEL_IN_DSI0_FROM_DSC_WRAP0_OUT = (0 << 0), + SEL_IN_DSI0_FROM_DISP_DITHER0 = (1 << 0), +}; + +enum { + SEL_IN_DP_INTF0_FROM_DSC_WRAP0C1_OUT = (0 << 0), + SEL_IN_DP_INTF0_FROM_VPP_MERGE = (1 << 0), + SEL_IN_DP_INTF0_FROM_DISP_DITHER0 = (3 << 0), +}; + +enum { + SEL_OUT_DISP_DITHER0_TO_DSC_WRAP0_IN = (0 << 0), + SEL_OUT_DISP_DITHER0_TO_DSI0 = (1 << 0), + SEL_OUT_DISP_DITHER0_TO_VPP_MERGE0 = (6 << 0), + SEL_OUT_DISP_DITHER0_TO_DP_INTF0 = (7 << 0), +}; + +struct disp_mutex_regs { + u32 inten; + u32 intsta; + u32 reserved0[6]; + struct { + u32 en; + u32 dummy; + u32 rst; + u32 ctl; + u32 mod; + u32 reserved[3]; + } mutex[12]; +}; + +static struct disp_mutex_regs *const disp_mutex = (void *)DISP_MUTEX_BASE; + +enum { + MUTEX_MOD_DISP_OVL0 = BIT(0), + MUTEX_MOD_DISP_RDMA0 = BIT(2), + MUTEX_MOD_DISP_COLOR0 = BIT(3), + MUTEX_MOD_DISP_CCORR0 = BIT(4), + MUTEX_MOD_DISP_AAL0 = BIT(5), + MUTEX_MOD_DISP_GAMMA0 = BIT(6), + MUTEX_MOD_DISP_DITHER0 = BIT(7), + MUTEX_MOD_DISP_POSTMASK0 = BIT(24), + MUTEX_MOD_MAIN_PATH = MUTEX_MOD_DISP_OVL0 | + MUTEX_MOD_DISP_RDMA0 | + MUTEX_MOD_DISP_COLOR0 | + MUTEX_MOD_DISP_CCORR0 | + MUTEX_MOD_DISP_AAL0 | + MUTEX_MOD_DISP_GAMMA0 | + MUTEX_MOD_DISP_POSTMASK0 | + MUTEX_MOD_DISP_DITHER0, +}; + +enum { + MUTEX_SOF_SINGLE_MODE = 0, + MUTEX_SOF_DSI0 = 1, + MUTEX_SOF_DPI0 = 2, + MUTEX_SOF_DP_INTF0 = 3, +}; + +struct disp_ccorr_regs { + u32 en; + u32 reset; + u32 inten; + u32 intsta; + u32 status; + u32 reserved0[3]; + u32 cfg; + u32 reserved1[3]; + u32 size; + u32 reserved2[27]; + u32 shadow; +}; +check_member(disp_ccorr_regs, shadow, 0xa0); + +struct disp_gamma_regs { + u32 en; + u32 reset; + u32 inten; + u32 intsta; + u32 status; + u32 reserved0[3]; + u32 cfg; + u32 reserved1[3]; + u32 size; +}; +check_member(disp_gamma_regs, size, 0x30); + +struct disp_aal_regs { + u32 en; + u32 reset; + u32 inten; + u32 intsta; + u32 status; + u32 reserved0[3]; + u32 cfg; + u32 reserved1[3]; + u32 size; + u32 reserved2[47]; + u32 shadow; + u32 reserved3[249]; + u32 output_size; +}; +check_member(disp_aal_regs, shadow, 0xf0); +check_member(disp_aal_regs, output_size, 0x4d8); + +struct disp_postmask_regs { + u32 en; + u32 reserved0[7]; + u32 cfg; + u32 reserved1[3]; + u32 size; +}; +check_member(disp_postmask_regs, size, 0x30); + +struct disp_dither_regs { + u32 en; + u32 reset; + u32 inten; + u32 intsta; + u32 status; + u32 reserved0[3]; + u32 cfg; + u32 reserved1[3]; + u32 size; + u32 reserved2[51]; + u32 shadow; +}; +check_member(disp_dither_regs, shadow, 0x100); + +enum { + PQ_EN = BIT(0), + PQ_RELAY_MODE = BIT(0), + PQ_ENGINE_EN = BIT(1), +}; + +static struct disp_ccorr_regs *const disp_ccorr = (void *)DISP_CCORR0_BASE; +static struct disp_aal_regs *const disp_aal = (void *)DISP_AAL0_BASE; +static struct disp_gamma_regs *const disp_gamma = (void *)DISP_GAMMA0_BASE; +static struct disp_postmask_regs *const disp_postmask = (void *)DISP_POSTMASK0_BASE; +static struct disp_dither_regs *const disp_dither = (void *)DISP_DITHER0_BASE; + +enum { + SMI_LARB_PORT_L0_OVL_RDMA0 = 0xF88, +}; + +void mtk_ddp_init(void); +void mtk_ddp_mode_set(const struct edid *edid); + +#endif