Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Krystian Hebel has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83064?usp=email )
Change subject: cpu/x86/smm: Add save state ops for different save states
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/amd/smm/amd64_save_state.c:
https://review.coreboot.org/c/coreboot/+/83064/comment/f77694e3_64bb3685?usp... :
PS4, Line 117: 0x00020064
This one doesn't have I/O Instruction Restart bit set, which in turn means that `smm_io_trap` in `amd64_apmc_node()` won't have useful data. It is used by QEMU, which is the sole reason why I couldn't use changes from this chain in CB:82558.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83064?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67ab44fbdca5fac5837d32ffda5caad61e534473
Gerrit-Change-Number: 83064
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 04 Jul 2024 10:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No