Attention is currently required from: Robert Zieba, Raul Rangel, Rob Barnes, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )
Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices
......................................................................
Patch Set 13:
(3 comments)
File src/soc/amd/cezanne/fch.c:
PS13:
without having looked into the details: can the newly added code in gpp_clk_setup be factored out into a separate function?
https://review.coreboot.org/c/coreboot/+/61259/comment/eda34e4f_8173e6b6
PS13, Line 11: #include "chip.h"
i think coreboot usually puts the "" includes after the <> includes. reordering includes should be done in a separate patch
File src/soc/amd/cezanne/platform_descriptors.c:
PS13:
i'd add the port descriptors of all boards to their ramstage instead of introducing a weak function here. the solution with the weak function would also result in having different dxio descriptor data in romstage and ramstage which makes things much more difficult to debug
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77389372c60bdec572622a3b49484d4789fd4e4c
Gerrit-Change-Number: 61259
Gerrit-PatchSet: 13
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 04 Feb 2022 22:39:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment