Attention is currently required from: Ravi Kumar Bokka, Nico Huber, Furquan Shaikh, Paul Menzel, Julius Werner, Prasad Malisetty, mturney mturney.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe host controller driver
......................................................................
Patch Set 89:
(5 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/53902/comment/790b635c_d471bd20
PS89, Line 78: 0x100000
I thought that it turned out this was actually 4K?
File src/soc/qualcomm/sc7280/pcie_host.c:
https://review.coreboot.org/c/coreboot/+/53902/comment/1039815a_fbfd05de
PS89, Line 34: db
dbi
https://review.coreboot.org/c/coreboot/+/53902/comment/1029a818_5c625999
PS89, Line 55: gpio_t perst;
what if there is more than one endpoint downstream of the RC? would they still always use the same PERST# GPIO?
https://review.coreboot.org/c/coreboot/+/53902/comment/f62ac335_79017604
PS89, Line 110: static const struct qcom_qmp_phy_init_tbl sc7280_qmp_pcie_serdes_tbl[] = {
Are all of these static SERDES and PCIe RX/TX tables chipset specific, or possily board specific?
https://review.coreboot.org/c/coreboot/+/53902/comment/7794a962_57393036
PS89, Line 424: mdelay(100);
: gpio_set(perst, 1);
: mdelay(50);
same here, I think it's up to the mainboard specific code to ensure these delays are met.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccf60aa56541f5230fa9c3f821d7709615c36631
Gerrit-Change-Number: 53902
Gerrit-PatchSet: 89
Gerrit-Owner: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Wed, 04 May 2022 21:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment