Attention is currently required from: Kyösti Mälkki.
Riku Viitanen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74906?usp=email )
Change subject: mb/hp: Add new port for compaq_8300_elite_usdt ......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/hp/compaq_8300_elite_usdt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74906/comment/827834f5_c6811381 : PS1, Line 9: register "gen2_dec" = "0x00fc0801"
The latter seems like reasonable I/O decode for 0x800. […]
I have no idea. These magic numbers were decided by autoport. Can you help me figure out if they need changing?
https://review.coreboot.org/c/coreboot/+/74906/comment/8418aa26_d4ae4c7a : PS1, Line 80: io 0x60 = 0x600
LPC decode required from 0x600
How would I go about adding that? I'm a complete n00b.
-
Riku Viitanen (Code Review)