Change in coreboot[master]: autoport: use GMA_STATIC_DISPLAYS

[Iru Cai (vimacs) (Code Review)]

Hello Iru Cai,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/40364

to review the following change.

Change subject: autoport: use GMA_STATIC_DISPLAYS
......................................................................

autoport: use GMA_STATIC_DISPLAYS

Change-Id: Ie988b2caeb2cdc07a3d6466b7ae3501df469ef41
Signed-off-by: Iru Cai 
---
M util/autoport/sandybridge.go
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/40364/1

diff --git a/util/autoport/sandybridge.go b/util/autoport/sandybridge.go
index a64ef7a..6f57847 100644
--- a/util/autoport/sandybridge.go
+++ b/util/autoport/sandybridge.go
@@ -1,5 +1,7 @@
 package main

+import "fmt"
+
 type sandybridgemc struct {
 }

@@ -30,7 +32,7 @@
    		"gpu_panel_power_cycle_delay":         FormatInt32(inteltool.IGD[0xc7210] & 0xff),
    		"gpu_cpu_backlight":                   FormatHex32(inteltool.IGD[0x48254]),
    		"gpu_pch_backlight":                   FormatHex32((inteltool.IGD[0xc8254] >> 16) * 0x10001),
-			"gfx.use_spread_spectrum_clock":       FormatBool((inteltool.IGD[0xc6200]>>12)&1 != 0),
+			"gfx": fmt.Sprintf("GMA_STATIC_DISPLAYS(%d)", (inteltool.IGD[0xc6200] >> 12) & 1),
    	},
    	Children: []DevTreeNode{
    		{

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40364 )

Change subject: autoport: use GMA_STATIC_DISPLAYS
......................................................................

Patch Set 1: Code-Review+2

Pl

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40364 )

Change subject: autoport: use GMA_STATIC_DISPLAYS
......................................................................

autoport: use GMA_STATIC_DISPLAYS

Change-Id: Ie988b2caeb2cdc07a3d6466b7ae3501df469ef41
Signed-off-by: Iru Cai 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40364
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M util/autoport/sandybridge.go
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/util/autoport/sandybridge.go b/util/autoport/sandybridge.go
index a64ef7a..6f57847 100644
--- a/util/autoport/sandybridge.go
+++ b/util/autoport/sandybridge.go
@@ -1,5 +1,7 @@
 package main

+import "fmt"
+
 type sandybridgemc struct {
 }

@@ -30,7 +32,7 @@
    		"gpu_panel_power_cycle_delay":         FormatInt32(inteltool.IGD[0xc7210] & 0xff),
    		"gpu_cpu_backlight":                   FormatHex32(inteltool.IGD[0x48254]),
    		"gpu_pch_backlight":                   FormatHex32((inteltool.IGD[0xc8254] >> 16) * 0x10001),
-			"gfx.use_spread_spectrum_clock":       FormatBool((inteltool.IGD[0xc6200]>>12)&1 != 0),
+			"gfx": fmt.Sprintf("GMA_STATIC_DISPLAYS(%d)", (inteltool.IGD[0xc6200] >> 12) & 1),
    	},
    	Children: []DevTreeNode{
    		{

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40364 )

Change subject: autoport: use GMA_STATIC_DISPLAYS
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2378
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2377
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2376

Please note: This test is under development and might not be accurate at all!