Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan, Nico Huber, Saurabh Mishra.
Saurabh Mishra has uploaded a new patch set (#5) to the change originally created by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
The following approvals got outdated and were removed: Code-Review+1 by Nico Huber, Code-Review+1 by Saurabh Mishra, Verified+1 by build bot (Jenkins)
Change subject: Fix no-op for empty arg in Makefile conditional ......................................................................
Fix no-op for empty arg in Makefile conditional
This change addresses an issue where the Makefile failed with the error: /bin/bash: -c: option requires an argument make: *** [Makefile.mk:1261: build/coreboot.pre] Error 2
The error was due to an empty third argument `$(3)` in a conditional `$(if ...)` statement. The original line did not have an explicit no-op for the case when `$(3)` is empty, leading to an incomplete command.
By adding a colon `:` as a no-op command in the else-part of the `$(if ...)`, we ensure execution of a harmless command when `$(3)` is empty, preventing the Makefile from failing due to a missing argument.
This fix ensures compatibility with newer shell environments and prevents the Makefile from breaking under the specified conditions.
Change-Id: I276e89792779832edf325d4f781aa8df101e9091 Signed-off-by: Manigandan, Balaji balaji.manigandan@intel.com --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83887/5