Attention is currently required from: Arthur Heymans, David Hendricks, Jonathan Zhang, Martin L Roth, Paul Menzel.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68593?usp=email )
Change subject: acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS12:
Why is this patch still open? CB:77416, which you +1'd a few days ago, should suffice. You just need to reply to Arthur's comment since you're the one moaning about 'dead code".
David, you are right I'm the only one moaning about dead code and try to clean up the code.
Worst, I'm doing this for absolutely zero € !
Wandering why I'm doing this for free !
Thank you, from now on, I'll save my time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68593?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I222478572a9e5efadd6719a164558833298e4c99
Gerrit-Change-Number: 68593
Gerrit-PatchSet: 12
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 18 Sep 2023 22:42:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment