Change in coreboot[master]: coreboot/Makefile: display error when spaces in path of toplevel make...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Name of user not set (Code Review)

16 Sep 2019 16 Sep '19

12:36 p.m.

Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35434 )

Change subject: coreboot/Makefile: display error when spaces in path of toplevel makefile ......................................................................

coreboot/Makefile: display error when spaces in path of toplevel makefile

coreboot toplevel makefile breaks when path to the coreboot directory contains spaces. This patch displays a reasonable message to the user whenever spaces are found within the path to the coreboot direcrory.

Change-Id: Id11deffa01ddca1ff9332d67c7aa33a382b4cdc7 Signed-off-by: Sourabh Kashyap sourabhka@hcl.com --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/35434/1

diff --git a/Makefile b/Makefile index f0a22a5..7911801 100644 --- a/Makefile +++ b/Makefile @@ -30,6 +30,9 @@ ## SUCH DAMAGE. ##

+ifneq ($(words $(CURDIR)),1) + $(error Error: Path to the main directory cannot contain spaces) +endif top := $(CURDIR) src := src srck := $(top)/util/kconfig

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Name of user not set (Code Review)

16 Sep 16 Sep

12:39 p.m.

Hello Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35434

to look at the new patch set (#2).

Change subject: coreboot/Makefile: display error when spaces in path of toplevel makefile ......................................................................

coreboot/Makefile: display error when spaces in path of toplevel makefile

This commit addresses coreboot ticket #179.

Change-Id: Id11deffa01ddca1ff9332d67c7aa33a382b4cdc7 Signed-off-by: Sourabh Kashyap sourabhka@hcl.com --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/35434/2

Patrick Georgi (Code Review)

26 Sep 26 Sep

12:10 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35434 )

Change subject: coreboot/Makefile: display error when spaces in path of toplevel makefile ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id11deffa01ddca1ff9332d67c7aa33a382b4cdc7 Gerrit-Change-Number: 35434 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Comment-Date: Thu, 26 Sep 2019 10:10:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:11 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35434 )

Change subject: coreboot/Makefile: display error when spaces in path of toplevel makefile ......................................................................

coreboot/Makefile: display error when spaces in path of toplevel makefile

This commit addresses coreboot ticket #179.

Change-Id: Id11deffa01ddca1ff9332d67c7aa33a382b4cdc7 Signed-off-by: Sourabh Kashyap sourabhka@hcl.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35434 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/Makefile b/Makefile index 52cba69..35a4b32 100644 --- a/Makefile +++ b/Makefile @@ -30,6 +30,9 @@ ## SUCH DAMAGE. ##

+ifneq ($(words $(CURDIR)),1) + $(error Error: Path to the main directory cannot contain spaces) +endif top := $(CURDIR) src := src srck := $(top)/util/kconfig

-- To view, visit https://review.coreboot.org/c/coreboot/+/35434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id11deffa01ddca1ff9332d67c7aa33a382b4cdc7 Gerrit-Change-Number: 35434 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-MessageType: merged

Paul Menzel (Code Review)

12:27 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35434 )

Change subject: coreboot/Makefile: display error when spaces in path of toplevel makefile ......................................................................

Patch Set 3:

(1 comment)

Thank you for contributing to coreboot.

https://review.coreboot.org/c/coreboot/+/35434/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35434/3//COMMIT_MSG@14 PS3, Line 14: This commit addresses coreboot ticket #179. I’d prefer the tag below for future fixes.

...

Fixes: https://ticket.coreboot.org/issues/179

-- To view, visit https://review.coreboot.org/c/coreboot/+/35434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id11deffa01ddca1ff9332d67c7aa33a382b4cdc7 Gerrit-Change-Number: 35434 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Comment-Date: Thu, 26 Sep 2019 10:27:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

2:50 p.m.

Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35434 )

Change subject: coreboot/Makefile: display error when spaces in path of toplevel makefile ......................................................................

Patch Set 3:

(1 comment)

Thanks!

https://review.coreboot.org/c/coreboot/+/35434/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35434/3//COMMIT_MSG@14 PS3, Line 14: This commit addresses coreboot ticket #179.

...

I’d prefer the tag below for future fixes. […]

Definitely follow the same from now. Done for CB:35098 as well.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id11deffa01ddca1ff9332d67c7aa33a382b4cdc7 Gerrit-Change-Number: 35434 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Comment-Date: Thu, 26 Sep 2019 12:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

1934

days inactive

1944

days old

coreboot-gerrit@coreboot.org

5 comments

3 participants

tags (0)

participants (3)

Name of user not set (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)