Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Paul Menzel, Zheng Bao, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59308 )
Change subject: amdfwtool: Upgrade "relative address" to four address modes ......................................................................
Patch Set 3:
(6 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133464): https://review.coreboot.org/c/coreboot/+/59308/comment/6342f0c0_d72c1323 PS3, Line 355: ((mode) == 2 ? (offset) - ctx.current_table : (offset)) )) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133464): https://review.coreboot.org/c/coreboot/+/59308/comment/5c6e54c7_4b22bcf3 PS3, Line 357: #define RUN_TO_OFFSET(ctx, run) ((ctx).address_mode == 0 ? (run) - RUN_BASE(ctx) : (run)) /* TODO: */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133464): https://review.coreboot.org/c/coreboot/+/59308/comment/d80bff3b_16873900 PS3, Line 478: bdir->header.additional_info_fields.dir_size = table_size / 0x1000;; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133464): https://review.coreboot.org/c/coreboot/+/59308/comment/e7bb4494_4d8c4295 PS3, Line 955: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133464): https://review.coreboot.org/c/coreboot/+/59308/comment/8fd94cfd_caaf9a43 PS3, Line 961: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133464): https://review.coreboot.org/c/coreboot/+/59308/comment/3736408f_afa4c759 PS3, Line 974: biosdir->entries[count].address_mode = SET_ADDR_MODE(1, biosdir); line over 96 characters