Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44647 )
Change subject: util: update gen_part_id tool to include memory type ......................................................................
util: update gen_part_id tool to include memory type
Add "MEMORY_TYPE = lpddr4x" to the generated Makefile.inc to indicate this is lpddr4x memory and to use the generic SPDs from the lpddr4x respository of SPDs.
BUG=b:160157545 TEST=run gen_part_id for volteer and verify that it adds the line "MEMORY_TYPE = lpddr4x" to the makefile produced.
Change-Id: I416690ae8aff8052474b16ef0d3e940e72e6a2fb Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M util/spd_tools/intel/lp4x/gen_part_id.go 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44647/1
diff --git a/util/spd_tools/intel/lp4x/gen_part_id.go b/util/spd_tools/intel/lp4x/gen_part_id.go index 6c2ca11..af41432 100644 --- a/util/spd_tools/intel/lp4x/gen_part_id.go +++ b/util/spd_tools/intel/lp4x/gen_part_id.go @@ -174,6 +174,7 @@ var s string
s += fmt.Sprintf("%s\n%s\n\n", generatedCodeLicense, autoGeneratedInfo) + s += fmt.Sprintf("MEMORY_TYPE = lpddr4x\n\n") s += fmt.Sprintf("SPD_SOURCES =\n")
for i := 0; i < len(partIdList); i++ {
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44647
to look at the new patch set (#2).
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
util: update lp4x gen_part_id tool to include memory type
Add "MEMORY_TYPE = lpddr4x" to the generated Makefile.inc to indicate this is lpddr4x memory and to use the generic SPDs from the lpddr4x respository of SPDs.
BUG=b:160157545 TEST=run gen_part_id for volteer and verify that it adds the line "MEMORY_TYPE = lpddr4x" to the makefile produced.
Change-Id: I416690ae8aff8052474b16ef0d3e940e72e6a2fb Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M util/spd_tools/intel/lp4x/gen_part_id.go 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44647/2
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44647
to look at the new patch set (#6).
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
util: update lp4x gen_part_id tool to include memory type
Add "MEMORY_TYPE = lpddr4x" to the generated Makefile.inc to indicate this is lpddr4x memory and to use the generic SPDs from the lpddr4x respository of SPDs.
BUG=b:160157545 TEST=run gen_part_id for volteer and verify that it adds the line "MEMORY_TYPE = lpddr4x" to the makefile produced.
Change-Id: I416690ae8aff8052474b16ef0d3e940e72e6a2fb Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M util/spd_tools/intel/lp4x/gen_part_id.go 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44647/6
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44647 )
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
Patch Set 6: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44647 )
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44647/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44647/6//COMMIT_MSG@9 PS6, Line 9: lpddr4x lp4x
https://review.coreboot.org/c/coreboot/+/44647/6//COMMIT_MSG@15 PS6, Line 15: lpddr4x lp4x
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44647 )
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
Patch Set 12: Code-Review+1
Hello build bot (Jenkins), Furquan Shaikh, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44647
to look at the new patch set (#14).
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
util: update lp4x gen_part_id tool to include memory type
Add "MEMORY_TYPE = lp4x" to the generated Makefile.inc to indicate this is lpddr4x memory and to use the generic SPDs from the lpddr4x respository of SPDs.
BUG=b:160157545 TEST=run gen_part_id for volteer and verify that it adds the line "MEMORY_TYPE = lp4x" to the makefile produced.
Change-Id: I416690ae8aff8052474b16ef0d3e940e72e6a2fb Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M util/spd_tools/intel/lp4x/gen_part_id.go 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44647/14
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44647 )
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44647/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44647/6//COMMIT_MSG@9 PS6, Line 9: lpddr4x
lp4x
Done
https://review.coreboot.org/c/coreboot/+/44647/6//COMMIT_MSG@15 PS6, Line 15: lpddr4x
lp4x
Done
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44647 )
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
util: update lp4x gen_part_id tool to include memory type
Add "MEMORY_TYPE = lp4x" to the generated Makefile.inc to indicate this is lpddr4x memory and to use the generic SPDs from the lpddr4x respository of SPDs.
BUG=b:160157545 TEST=run gen_part_id for volteer and verify that it adds the line "MEMORY_TYPE = lp4x" to the makefile produced.
Change-Id: I416690ae8aff8052474b16ef0d3e940e72e6a2fb Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44647 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Furquan Shaikh furquan@google.com --- M util/spd_tools/intel/lp4x/gen_part_id.go 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/util/spd_tools/intel/lp4x/gen_part_id.go b/util/spd_tools/intel/lp4x/gen_part_id.go index 6c2ca11..7ed255c 100644 --- a/util/spd_tools/intel/lp4x/gen_part_id.go +++ b/util/spd_tools/intel/lp4x/gen_part_id.go @@ -174,6 +174,7 @@ var s string
s += fmt.Sprintf("%s\n%s\n\n", generatedCodeLicense, autoGeneratedInfo) + s += fmt.Sprintf("MEMORY_TYPE = lp4x\n\n") s += fmt.Sprintf("SPD_SOURCES =\n")
for i := 0; i < len(partIdList); i++ {
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44647 )
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
Patch Set 16:
I was in the process of uploading the lp4x- prefix fix but this now shows as merged (which is why I didn't resolve that comment yet). I will rearrange and add it to the top of this stack instead.
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44647 )
Change subject: util: update lp4x gen_part_id tool to include memory type ......................................................................
Patch Set 16:
Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16636 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16635 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16634 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16633 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16632 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16638 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16637
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Rob Barnes (Code Review)