Change in coreboot[master]: volteer: Create delbin variant

[Zhuohao Lee (Code Review)]

Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42709 )

Change subject: volteer: Create delbin variant
......................................................................

volteer: Create delbin variant

Create the delbin variant of the volteer reference board by copying
the template files to a new directory named for the variant.

(Auto-Generated by create_coreboot_variant.sh version 4.1.1).

BUG=b:158797761
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_DELBIN

Signed-off-by: Zhuohao Lee 
Change-Id: Icf5fc6b9cc6a7c47e52103b2d396bcddb26adf50
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/delbin/include/variant/ec.h
A src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h
A src/mainboard/google/volteer/variants/delbin/overridetree.cb
5 files changed, 46 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42709/1

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index 99a08a3..fa39ddf 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -73,6 +73,7 @@
    default "Trondo" if BOARD_GOOGLE_TRONDO
    default "Volteer" if BOARD_GOOGLE_VOLTEER
    default "Voxel" if BOARD_GOOGLE_VOXEL
+	default "Delbin" if BOARD_GOOGLE_DELBIN

config MAX_CPUS
    int
@@ -105,6 +106,7 @@
    default "trondo" if BOARD_GOOGLE_TRONDO
    default "volteer" if BOARD_GOOGLE_VOLTEER
    default "voxel" if BOARD_GOOGLE_VOXEL
+	default "delbin" if BOARD_GOOGLE_DELBIN

config VARIANT_HAS_MIPI_CAMERA
    bool
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index 6920aaf..0aa91ab 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -29,3 +29,7 @@
 config BOARD_GOOGLE_VOXEL
    bool "-> Voxel"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
+
+config BOARD_GOOGLE_DELBIN
+	bool "-> Delbin"
+	select BOARD_GOOGLE_BASEBOARD_VOLTEER
diff --git a/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h b/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h
new file mode 100644
index 0000000..7a2a6ff
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __VARIANT_EC_H__
+#define __VARIANT_EC_H__
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h b/src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h
new file mode 100644
index 0000000..5839395
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h
@@ -0,0 +1,26 @@
+/*
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+#include <baseboard/gpio.h>
+
+/* Memory configuration board straps */
+/* Copied from baseboard and may need to change for the new variant. */
+#define GPIO_MEM_CONFIG_0	GPP_C12
+#define GPIO_MEM_CONFIG_1	GPP_C15
+#define GPIO_MEM_CONFIG_2	GPP_C14
+#define GPIO_MEM_CONFIG_3	GPP_D15
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
new file mode 100644
index 0000000..32204c5
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
@@ -0,0 +1,6 @@
+chip soc/intel/tigerlake
+
+	device domain 0 on
+	end
+
+end

[Zhuohao Lee (Code Review)]

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42709 )

Change subject: volteer: Create delbin variant
......................................................................

Patch Set 2:

This change is ready for review.

[Zhuohao Lee (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42709

to look at the new patch set (#3).

Change subject: volteer: Create delbin variant
......................................................................

volteer: Create delbin variant

Create the delbin variant of the volteer reference board by copying
the template files to a new directory named for the variant.

(Auto-Generated by create_coreboot_variant.sh version 4.1.1).

BUG=b:158797761
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_DELBIN

Signed-off-by: Zhuohao Lee 
Change-Id: Icf5fc6b9cc6a7c47e52103b2d396bcddb26adf50
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl
A src/mainboard/google/volteer/variants/delbin/include/variant/ec.h
A src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h
A src/mainboard/google/volteer/variants/delbin/overridetree.cb
6 files changed, 49 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42709/3

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42709 )

Change subject: volteer: Create delbin variant
......................................................................

Patch Set 3: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42709 )

Change subject: volteer: Create delbin variant
......................................................................

Patch Set 3: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42709 )

Change subject: volteer: Create delbin variant
......................................................................

volteer: Create delbin variant

Create the delbin variant of the volteer reference board by copying
the template files to a new directory named for the variant.

(Auto-Generated by create_coreboot_variant.sh version 4.1.1).

BUG=b:158797761
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_DELBIN

Signed-off-by: Zhuohao Lee 
Change-Id: Icf5fc6b9cc6a7c47e52103b2d396bcddb26adf50
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42709
Tested-by: build bot (Jenkins) 
Reviewed-by: Sumeet R Pawnikar 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl
A src/mainboard/google/volteer/variants/delbin/include/variant/ec.h
A src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h
A src/mainboard/google/volteer/variants/delbin/overridetree.cb
6 files changed, 49 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Sumeet R Pawnikar: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index 44c393f..e3f59a0 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -73,6 +73,7 @@
    default "Trondo" if BOARD_GOOGLE_TRONDO
    default "Volteer" if BOARD_GOOGLE_VOLTEER
    default "Voxel" if BOARD_GOOGLE_VOXEL
+	default "Delbin" if BOARD_GOOGLE_DELBIN

config MAX_CPUS
    int
@@ -105,6 +106,7 @@
    default "trondo" if BOARD_GOOGLE_TRONDO
    default "volteer" if BOARD_GOOGLE_VOLTEER
    default "voxel" if BOARD_GOOGLE_VOXEL
+	default "delbin" if BOARD_GOOGLE_DELBIN

config VARIANT_HAS_MIPI_CAMERA
    bool
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index 51ee6cd..1859631 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -30,3 +30,7 @@
 config BOARD_GOOGLE_VOXEL
    bool "-> Voxel"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
+
+config BOARD_GOOGLE_DELBIN
+	bool "-> Delbin"
+	select BOARD_GOOGLE_BASEBOARD_VOLTEER
diff --git a/src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl
new file mode 100644
index 0000000..189cafe
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <baseboard/acpi/dptf.asl>
diff --git a/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h b/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h
new file mode 100644
index 0000000..7a2a6ff
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __VARIANT_EC_H__
+#define __VARIANT_EC_H__
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h b/src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h
new file mode 100644
index 0000000..5839395
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/delbin/include/variant/gpio.h
@@ -0,0 +1,26 @@
+/*
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+#include <baseboard/gpio.h>
+
+/* Memory configuration board straps */
+/* Copied from baseboard and may need to change for the new variant. */
+#define GPIO_MEM_CONFIG_0	GPP_C12
+#define GPIO_MEM_CONFIG_1	GPP_C15
+#define GPIO_MEM_CONFIG_2	GPP_C14
+#define GPIO_MEM_CONFIG_3	GPP_D15
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
new file mode 100644
index 0000000..32204c5
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
@@ -0,0 +1,6 @@
+chip soc/intel/tigerlake
+
+	device domain 0 on
+	end
+
+end