Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83347?usp=email )
Change subject: xcompile: Add -Wextra with temporary exceptions
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I would have done the opposite.
"Wextra" may evolve with new options which may generate compilation errors in the future.
On the other hand, activating the options individually seems more appropriate to me.
Once you have covered all of the "Wextra" options, you can activate it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83347?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60915cb66581dc2c9b6807335fd0e214b45e76d6
Gerrit-Change-Number: 83347
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Fri, 05 Jul 2024 09:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No