Attention is currently required from: Felix Held, Fred Reitberger, George Burgess, Martin L Roth, Matt DeVillier.
Raul Rangel has posted comments on this change by George Burgess. ( https://review.coreboot.org/c/coreboot/+/83412?usp=email )
Change subject: amdfwtool: adjust sign of constant
......................................................................
Patch Set 1:
(1 comment)
File util/amdfwtool/amdfwtool.h:
https://review.coreboot.org/c/coreboot/+/83412/comment/b35cf07d_1b3eeedb?usp... :
PS1, Line 146: int
Maybe just change this to an `unsigned int`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83412?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd83be8302e8a717db7e7dc86a403b5648976586
Gerrit-Change-Number: 83412
Gerrit-PatchSet: 1
Gerrit-Owner: George Burgess
gbiv@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jon Murphy
jpmurphy@google.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: George Burgess
gbiv@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Jul 2024 14:35:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No