Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, John Zhao.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information
......................................................................
Patch Set 7:
(1 comment)
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/56024/comment/15526362_bd67c07e
PS6, Line 129: struct acpi_pld pld;
:
: if (!usb_device || !usb_device->chip_info ||
: usb_device->chip_ops != &drivers_usb_acpi_ops)
: return NULL;
:
: if (config->use_custom_pld)
: memcpy(&pld, &config->custom_pld, sizeof(pld));
: else
: acpi_pld_fill_usb(&pld, config->type, &config->group);
:
: return &pld;
Can I add structure pointer PLD to chip.h and then malloc memory to it and reuse it? […]
I have changed current function to have pld pointer as input from caller, so that we don't need to worry about keeping the context.
Please let me know if it's okay 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf140ce1965dce3a812aa2701ce0e29b34ab3e7
Gerrit-Change-Number: 56024
Gerrit-PatchSet: 7
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Abhijeet Rao
abhijeet.rao@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Comment-Date: Fri, 09 Jul 2021 10:28:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment