Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34725 )
Change subject: soc/intel/skylake: Use new power-failure-state API
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34725/6/src/soc/intel/skylake/pmc.c
File src/soc/intel/skylake/pmc.c:
https://review.coreboot.org/c/coreboot/+/34725/6/src/soc/intel/skylake/pmc.c...
PS6, Line 52: * the power (from G3 State)
I'm not the author of that comment, but I agree with them that […]
Sorry if we have any rules about comment line length that I missed. If we
don't and you think we should have, we can have that discussion on the
mailing list.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie72753764ecd876e6cb999fa0074d1114ae5efcf
Gerrit-Change-Number: 34725
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 09 Aug 2019 09:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment