Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59051 )
Change subject: mb/google/guybrush/var/nipperkin: Update SPKR GPIO configuration
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/59051/comment/e217fb85_aac652b3
PS4, Line 87: PAD_NC(GPIO_70),
Please configure the following GPIOs in the baseboard here.
PAD_NC(GPIO_31),
PAD_GPO(GPIO_70, HIGH)
Please donot configure in the pcie_table. This signal needs to be set high only in ramstage
In Guybrush - For Board ID2:
PAD_GPO(GPIO_31, HIGH),
PAD_NC(GPIO_70)
In Nipperkin - For Board ID1:
PAD_GPO(GPIO_31, HIGH),
PAD_NC(GPIO_70)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d82292b116f53d85d9518364ffd2169bd915a7e
Gerrit-Change-Number: 59051
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Comment-Date: Tue, 16 Nov 2021 01:01:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment