Attention is currently required from: Jakub Czapiga, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu.
Felix Singer has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83930?usp=email )
Change subject: Revert "commonlib/bsd: Add strlen() and strnlen() functions"
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83930/comment/b37c2f29_47594e64?usp... :
PS3, Line 11: Reason for revert: b/359951393 breaking builds affecting many devices
Tried to add more context. […]
Okay. My point just is, using the numbers in the commit description suggests to the reader that the number is used at coreboot in some way, which is not the case and so it's confusing. It's only used within Google. For people outside of Google it's still not visible what that number is. I mean, I know but others might not.
So, how about using a header line as we have for others like Sign-off or Change-ID? Then it's crystal clear. I think that should work for your case too?
Example:
```
ChromeOS-Bug-ID: b/359951393
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83930?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Gerrit-Change-Number: 83930
Gerrit-PatchSet: 6
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 15 Aug 2024 19:10:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com