Attention is currently required from: Erin Park, Kapil Porwal, Subrata Banik, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75907?usp=email )
Change subject: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value. ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75907/comment/13ac5c14_99947023 : PS1, Line 6:
Subject line should not end with a period.
Please fix. (It’s the line below.)
https://review.coreboot.org/c/coreboot/+/75907/comment/fd3de4ac_8e84fc54 : PS1, Line 7: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value. Maybe: Default to Balance_Powersave policy
(How is it spelled in the datasheet?)
https://review.coreboot.org/c/coreboot/+/75907/comment/0aa3da38_13f9b590 : PS1, Line 9: meteorlake Meteor Lake
https://review.coreboot.org/c/coreboot/+/75907/comment/73b2920d_14b53bc2 : PS1, Line 10: best PnP user experience How is that measured? Plug and Play? Doesn’t it depend on the board?
https://review.coreboot.org/c/coreboot/+/75907/comment/3b44a0fc_7a795b24 : PS1, Line 13: Please add a Signed-off-by line.
(`make gitconfig` should set everything up for you locally.)
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/75907/comment/b472dbcf_08876feb : PS1, Line 56: #define ENERGY_POLICY_BALANCE_POWERSAVE 8 Please make that a separate commit und use tabs for alignment.