Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43519 )
Change subject: mb/google/zork: Drop mainboard.asl ......................................................................
mb/google/zork: Drop mainboard.asl
This change drops mainboard.asl from zork because none of the objects defined in it are used.
BUG=b:153879530
Change-Id: If5440bcbce39b4461b44acaec69561663b1ea329 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/dsdt.asl D src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl D src/mainboard/google/zork/variants/berknip/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/dalboz/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/morphius/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/trembyle/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl 9 files changed, 0 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/43519/1
diff --git a/src/mainboard/google/zork/dsdt.asl b/src/mainboard/google/zork/dsdt.asl index d256f66..8a8f4af 100644 --- a/src/mainboard/google/zork/dsdt.asl +++ b/src/mainboard/google/zork/dsdt.asl @@ -18,9 +18,6 @@ /* global NVS and variables */ #include <globalnvs.asl>
- /* Globals for the platform */ - #include <variant/acpi/mainboard.asl> - /* PCI IRQ mapping for the Southbridge */ #include <pcie.asl>
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl deleted file mode 100644 index e778970..0000000 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl +++ /dev/null @@ -1,14 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -/* Memory related values */ -Name(LOMH, 0x0) /* Start of unused memory in C0000-E0000 range */ -Name(PBAD, 0x0) /* Address of BIOS area (If TOM2 != 0, Addr >> 16) */ -Name(PBLN, 0x0) /* Length of BIOS area */ - -Name(PCBA, CONFIG_MMCONF_BASE_ADDRESS) /* Base address of PCIe config space */ -Name(PCLN, Multiply(0x100000, CONFIG_MMCONF_BUS_NUMBER)) /* Length of PCIe config space, 1MB each bus */ -Name(HPBA, 0xFED00000) /* Base address of HPET table */ - -/* Some global data */ -Name(OSVR, 3) /* Assume nothing. WinXp = 1, Vista = 2, Linux = 3, WinCE = 4 */ -Name(OSV, Ones) /* Assume nothing */ diff --git a/src/mainboard/google/zork/variants/berknip/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/berknip/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/berknip/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/dalboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/dalboz/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/dalboz/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/morphius/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/morphius/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/morphius/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/trembyle/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/trembyle/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/trembyle/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl>
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43519 )
Change subject: mb/google/zork: Drop mainboard.asl ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43519/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/43519/1/src/mainboard/google/zork/v... PS1, Line 8: Name(PCBA, CONFIG_MMCONF_BASE_ADDRESS) /* Base address of PCIe config space */ Ah, I removed the usage when I deleted the PCI Operation Region. Great!
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43519 )
Change subject: mb/google/zork: Drop mainboard.asl ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43519 )
Change subject: mb/google/zork: Drop mainboard.asl ......................................................................
mb/google/zork: Drop mainboard.asl
This change drops mainboard.asl from zork because none of the objects defined in it are used.
BUG=b:153879530
Change-Id: If5440bcbce39b4461b44acaec69561663b1ea329 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43519 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/dsdt.asl D src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl D src/mainboard/google/zork/variants/berknip/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/dalboz/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/morphius/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/trembyle/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl 9 files changed, 0 insertions(+), 38 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/zork/dsdt.asl b/src/mainboard/google/zork/dsdt.asl index d256f66..8a8f4af 100644 --- a/src/mainboard/google/zork/dsdt.asl +++ b/src/mainboard/google/zork/dsdt.asl @@ -18,9 +18,6 @@ /* global NVS and variables */ #include <globalnvs.asl>
- /* Globals for the platform */ - #include <variant/acpi/mainboard.asl> - /* PCI IRQ mapping for the Southbridge */ #include <pcie.asl>
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl deleted file mode 100644 index e778970..0000000 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl +++ /dev/null @@ -1,14 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -/* Memory related values */ -Name(LOMH, 0x0) /* Start of unused memory in C0000-E0000 range */ -Name(PBAD, 0x0) /* Address of BIOS area (If TOM2 != 0, Addr >> 16) */ -Name(PBLN, 0x0) /* Length of BIOS area */ - -Name(PCBA, CONFIG_MMCONF_BASE_ADDRESS) /* Base address of PCIe config space */ -Name(PCLN, Multiply(0x100000, CONFIG_MMCONF_BUS_NUMBER)) /* Length of PCIe config space, 1MB each bus */ -Name(HPBA, 0xFED00000) /* Base address of HPET table */ - -/* Some global data */ -Name(OSVR, 3) /* Assume nothing. WinXp = 1, Vista = 2, Linux = 3, WinCE = 4 */ -Name(OSV, Ones) /* Assume nothing */ diff --git a/src/mainboard/google/zork/variants/berknip/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/berknip/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/berknip/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/dalboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/dalboz/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/dalboz/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/morphius/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/morphius/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/morphius/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/trembyle/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/trembyle/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/trembyle/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl>
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)