Attention is currently required from: Furquan Shaikh, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58157 )
Change subject: soc/intel/common/cse: Reorganize firmware update checks for CSE Lite ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/58157/comment/a5eb075c_957c8f64 PS5, Line 651: (status == CSE_UPDATE_CORRUPTED
I added the check for corrupted case here because it seems safe to clear off data in case we encount […]
If the last update is downgrade case, then coreboot first clears the runtime data and triggers downgrade(erase & flash). So, during corrupted case, again clearing the data can be redundant. Coreboot still handles data mismatch error by checking the boot partition status, but it involves additional global reset as CSE boots from RO when the CSE finds data error. BTW, I am still fine with clearing the data proactively when coreboot finds CSE partition is corrupted.