Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth.
Maximilian Brune has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83226?usp=email )
Change subject: Makefile.mk: Use one line per *_common flag
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
By the paste, I've sorted CFLAGS by kind and alphabetically (https://review.coreboot. […]
I would prefer that to be a separate commit, since it is easier for review.
Now I can easily see that no option has been forgotten, since the order is the same.
And in the separate commit I just have to see that no more lines were added than removed (or vice versa) to see that it is good to go.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83226?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33c500e6eb74daf1e66c2b5e07b50f81c0f4587d
Gerrit-Change-Number: 83226
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 28 Jun 2024 11:26:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr