Attention is currently required from: Arthur Heymans. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63474 )
Change subject: cpu/x86/smm: Refactor creating a stub/save state map ......................................................................
Patch Set 7:
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/63474/comment/e0d251ce_3155b668 PS7, Line 121: cpus[i].entry = smbase - SMM_CODE_SEGMENT_SIZE * segment_number : - needed_ss_size * (i % cpus_per_segment) + SMM_ENTRY_OFFSET; : cpus[i].smbase = cpus[i].entry - SMM_ENTRY_OFFSET; suggestion: to avoid using SMM_ENTRY_OFFSET twice ``` cpus[i].smbase = smbase - SMM_CODE_SEGMENT_SIZE * segment_number - needed_ss_size * (i % cpus_per_segment); cpus[i].entry = cpus[i].smbase + SMM_ENTRY_OFFSET; ```