Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42745 )
Change subject: soc/intel: Configure PAVP at compile-time ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42745/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42745/13//COMMIT_MSG@11 PS13, Line 11: multimedia content) to Kconfig.
Maybe mention that it was hard enabled and this adds the option […]
I thought this was implied by "configure at compile-time?"
https://review.coreboot.org/c/coreboot/+/42745/13/src/soc/intel/common/Kconf... File src/soc/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/42745/13/src/soc/intel/common/Kconf... PS13, Line 43: the Management Engine, which is where this technology is implemented.
I would also recommend to disable it if one likes coreboot in general. I suspect […]
I agree that DRM keeps technology closed, but I don't follow why this would be a reason to choose to enable/disable a feature. Do you think the number of people enabling PAVP motivates Intel to continue supporting DRM?
This could be the case. Early CSME 11.0 versions of the pavp module aren't encrypted and contain some certificates. It may connect with a central server.
-
Benjamin Doron (Code Review)