Attention is currently required from: Bora Guvendik, Jamie Ryu, Jérémy Compostella, Saurabh Mishra, Subrata Banik, Wonkyu Kim.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83981?usp=email )
Change subject: soc/intel/common/gpio: support 16-bit CPU Port ID and vw mapping fix ......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/83981/comment/6cd1bd6f_721c26e6?usp... : PS4, Line 1063: if (comm->vw_map) {
okay. great. Let me try and test.
https://review.coreboot.org/c/coreboot/+/83981/comment/1574da0a_e77da607?usp... : PS4, Line 1071: }
what will happen when the `if` clause is not meeting? […]
This condition is to find the the pad from a range & it's offset from the first pad and returns false if not found.
start_pos will take care of PTL community 5 group B:
GPP_B_00: vw_base = 10h start pos = 3
Also, vw_map[i].base will take care of the jumped base and start_pos such as group D in community 5: ... GPP_B_25: 13h 1 GPP_D_00: 14h 0 <- not continue to use vw_base 13h start = 2. ...
In PTL SOC, this is added to pint to comm5 .vw_map: static const struct vw_map ptl_community5_vw_map[] = { {0x10, 3}, {0x14, 0}, };
Also, in community 3: ... GPP_A_17: 12h 1 GPP_H_00: 13h 0 <- not continue with vw_base 12h start_pos = 2 ...
This is added to point to comm5 .vw_map static const struct vw_map ptl_community3_vw_map[] = { {0x10, 0}, {0x13, 0}, };