Attention is currently required from: Jian Tong, Paul Menzel.
Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email )
Change subject: lotso: Add hid report address for gt7986u
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File src/mainboard/google/brox/variants/lotso/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83139/comment/b0ed6b53_4b3cc435?usp... :
PS2, Line 374: register "hid_report_addr" = "0x22c8c"
Please document in the commit message, where you got this value from.
This value is provided by the manufacturer,please refer to the following comments for details
https://partnerissuetracker.corp.google.com/issues/342932183#comment4
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83139?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8b18e0a2925e6fd36e3a470bde9910661b7558b8
Gerrit-Change-Number: 83139
Gerrit-PatchSet: 2
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Fri, 21 Jun 2024 02:20:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org