Attention is currently required from: Tarun Tuli, Kyle Lin, Frank Chu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71691 )
Change subject: mb/google/brya/var/marasov: Disable touch panel power for non-touch sku
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/marasov/fw_config.c:
https://review.coreboot.org/c/coreboot/+/71691/comment/a3dc13fb_ba684e1e
PS3, Line 23: fw_config_probe(FW_CONFIG(TOUCH, TOUCH_NONE)
if just 1 bits for touch and none touch, you don't have to probe again..just else
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71691
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4736f94481512806377b733b26fdc7290046c555
Gerrit-Change-Number: 71691
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kyle Lin
kylelinck@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kyle Lin
kylelinck@google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 09 Jan 2023 00:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment