Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80647?usp=email )
Change subject: soc/intel/common/lpc_lib: Demote printk for IO base value 0 ......................................................................
soc/intel/common/lpc_lib: Demote printk for IO base value 0
An IO base of 0 set for a LPC-attached PNP device is more likely a sign that the IO register is unused than an error, so demote the printk message from ERROR to SPEW and adjust the text accordingly.
TEST=build/boot purism/librem_cnl (Mini v2), verify no errors in cbmem log for unused registers in the SIO RTC.
Change-Id: I593f8e3c7eb9e877f89568fd63eabe12bb777f93 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/common/block/lpc/lpc_lib.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/80647/1
diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c index ed76049..6ca5c12 100644 --- a/src/soc/intel/common/block/lpc/lpc_lib.c +++ b/src/soc/intel/common/block/lpc/lpc_lib.c @@ -76,7 +76,7 @@
switch (base) { case 0: - printk(BIOS_ERR, "LPC IO decode base 0!\n"); + printk(BIOS_SPEW, "LPC IO decode base 0; skipping\n"); return; case 0x2e: case 0x2f: