Attention is currently required from: Sean Rhodes, Andy Pont, Paul Menzel, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support ......................................................................
Patch Set 52: Code-Review+2
(1 comment)
File src/ec/starlabs/merlin/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58343/comment/2d1fa938_3a41517b PS51, Line 14: ifeq ($(CONFIG_EC_STARLABS_NEED_ITE_BIN),y) : ifeq ($(CONFIG_EC_STARLABS_ADD_ITE_BIN),y) : ifeq ($(CONFIG_EC_STARLABS_IT_BIN_PATH),) : files_added:: warn_no_ite_fw : : PHONY+=warn_no_ite_fw : warn_no_ite_fw: : printf "\n\t** WARNING **\n" : printf "coreboot has been built without the ITE EC Firmware.\n" : printf "Do not flash this image. Your laptop's power button\n" : printf "may not respond when you press it.\n\n" : : else : add_ite_fw: $(obj)/coreboot.pre : $(CBFSTOOL) $(obj)/coreboot.pre write -r EC -f $(CONFIG_EC_STARLABS_IT_BIN_PATH) -u : : endif : endif : endif
Done
Looks like Gerrit shows two empty lines before the indented blocks. They're not actually empty lines. These would be lines 17 and 24 on patchset 52.