Change in coreboot[master]: common/block/imc: Add Integrated Memory Controller (IMC) driver

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34678 )

Change subject: common/block/imc: Add Integrated Memory Controller (IMC) driver
......................................................................

Patch Set 8:

(4 comments)

https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/... 
File src/soc/intel/common/block/imc/imc.c:

https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/... 
PS4, Line 32: #define SMBSTAT_RDO                    (1 << 31)  /* Read Data Valid */
> 1u

Ack

https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/... 
PS4, Line 37: #define SMBCMD_TRIGGER                 (1 << 31)  /* CMD Trigger */
> 1u

Ack

https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/... 
PS4, Line 96: int
> any reason to use int vs bool if only returning 0 and -1?

no hard reason as such, but just to follow other driver

https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/... 
PS4, Line 130: 	cntlbits = pci_mmio_read_config32(dev, SMBCNTL(mcid));
> this has been discussed offline. […]

Ack