Change in coreboot[master]: drivers/intel/fsp2_0: Add native implementation for FSP Debug Handler - coreboot-gerrit

23 Mar 2022


      Attention is currently required from: Subrata Banik, Andrey Petrov.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63007 )
Change subject: drivers/intel/fsp2_0: Add native implementation for FSP Debug Handler
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63007/comment/6a5c8249_d6b99aa7 
PS2, Line 29: serialport
nit:
`serial port`
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/63007/comment/0ccb1b20_cc41580e 
PS2, Line 355: _IN_COREBOOT
nit: this part of the name seems redundant 😊
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63007
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1018e67d70492b18c76531f9e78d3b58fa435cd4
Gerrit-Change-Number: 63007
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Comment-Date: Wed, 23 Mar 2022 15:35:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment