Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52671 )
Change subject: superio/nuvoton/npcd378: Fall back to non-negative value ......................................................................
superio/nuvoton/npcd378: Fall back to non-negative value
This change is needed to update the option API to use unsigned integers. The CMOS option system does not support negative numbers. So, adjust the call to get_int_option() to use 3 as fallback instead of -1.
Change-Id: I46c5f5c6f47f99379cbafc0d60258b99dc512e9d Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/52671 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/superio/nuvoton/npcd378/superio.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Patrick Rudolph: Looks good to me, approved
diff --git a/src/superio/nuvoton/npcd378/superio.c b/src/superio/nuvoton/npcd378/superio.c index 6a56ac8..3645832 100644 --- a/src/superio/nuvoton/npcd378/superio.c +++ b/src/superio/nuvoton/npcd378/superio.c @@ -68,8 +68,8 @@
npcd378_hwm_write_start(res->base);
- int fan_lvl = get_int_option("psu_fan_lvl", -1); - if (fan_lvl < 0 || fan_lvl > 7) + unsigned int fan_lvl = get_int_option("psu_fan_lvl", 3); + if (fan_lvl > 7) fan_lvl = 3;
uint8_t pwm = NPCD378_HWM_PSU_FAN_MIN +