Hash Hung has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38506 )
Change subject: mb/google/octopus/variants/lick: Set TCC offset for lick ......................................................................
mb/google/octopus/variants/lick: Set TCC offset for lick
Change tcc offset from 0 to 15 degree celsius for lick.
BUG=b:147198431 BRANCH=octopus TEST=Build, and verify test result by thermal team.
Signed-off-by: Hash.Hung hash1.hung@lcfc.corp-partner.google.com Change-Id: Ife6b02321145837e05c82f979998466b83317f86 --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/38506/1
diff --git a/src/mainboard/google/octopus/variants/lick/overridetree.cb b/src/mainboard/google/octopus/variants/lick/overridetree.cb index 41d078e..3aa369e 100644 --- a/src/mainboard/google/octopus/variants/lick/overridetree.cb +++ b/src/mainboard/google/octopus/variants/lick/overridetree.cb @@ -52,6 +52,8 @@ #| I2C5 | Audio | #| I2C6 | Trackpad | #+-------------------+---------------------------+ + register "tcc_offset" = "15" + register "common_soc_config" = "{ .gspi[0] = { .speed_mhz = 1,
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38506 )
Change subject: mb/google/octopus/variants/lick: Set TCC offset for lick ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38506/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38506/1//COMMIT_MSG@7 PS1, Line 7: mb/google/octopus/variants/lick: Set TCC offset for lick
Increase TCC offset to 15
*lick* is already in the prefix.
Hello Marco Chen, Henry Sun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38506
to look at the new patch set (#2).
Change subject: mb/google/octopus/variants/lick: Increase TCC offset to 15 ......................................................................
mb/google/octopus/variants/lick: Increase TCC offset to 15
Change tcc offset from 0 to 15 degree celsius for lick.
BUG=b:147198431 BRANCH=octopus TEST=Build, and verify test result by thermal team.
Signed-off-by: Hash.Hung hash1.hung@lcfc.corp-partner.google.com Change-Id: Ife6b02321145837e05c82f979998466b83317f86 --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/38506/2
Hash Hung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38506 )
Change subject: mb/google/octopus/variants/lick: Increase TCC offset to 15 ......................................................................
Patch Set 2:
(1 comment)
Update Commit message.
https://review.coreboot.org/c/coreboot/+/38506/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38506/1//COMMIT_MSG@7 PS1, Line 7: mb/google/octopus/variants/lick: Set TCC offset for lick
Increase TCC offset to 15 […]
Done. Thank you.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38506 )
Change subject: mb/google/octopus/variants/lick: Increase TCC offset to 15 ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38506 )
Change subject: mb/google/octopus/variants/lick: Increase TCC offset to 15 ......................................................................
mb/google/octopus/variants/lick: Increase TCC offset to 15
Change tcc offset from 0 to 15 degree celsius for lick.
BUG=b:147198431 BRANCH=octopus TEST=Build, and verify test result by thermal team.
Signed-off-by: Hash.Hung hash1.hung@lcfc.corp-partner.google.com Change-Id: Ife6b02321145837e05c82f979998466b83317f86 Reviewed-on: https://review.coreboot.org/c/coreboot/+/38506 Reviewed-by: Marco Chen marcochen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/lick/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/lick/overridetree.cb b/src/mainboard/google/octopus/variants/lick/overridetree.cb index 41d078e..3aa369e 100644 --- a/src/mainboard/google/octopus/variants/lick/overridetree.cb +++ b/src/mainboard/google/octopus/variants/lick/overridetree.cb @@ -52,6 +52,8 @@ #| I2C5 | Audio | #| I2C6 | Trackpad | #+-------------------+---------------------------+ + register "tcc_offset" = "15" + register "common_soc_config" = "{ .gspi[0] = { .speed_mhz = 1,
-
Hash Hung (Code Review) -
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)