Harshit Sharma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44259 )
Change subject: arch/x86: Select HAVE_ASAN_IN_RAMSTAGE ......................................................................
arch/x86: Select HAVE_ASAN_IN_RAMSTAGE
Enable ASan in ramstage for all x86 platforms.
Change-Id: Id5b3dc18368a5da6bdc70c84527b95d1688dc19f Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com --- M src/arch/x86/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/44259/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 660ff2d..d906436 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -4,6 +4,7 @@ bool select PCI select RELOCATABLE_MODULES + select HAVE_ASAN_IN_RAMSTAGE
# stage selectors for x86
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44259 )
Change subject: arch/x86: Select HAVE_ASAN_IN_RAMSTAGE ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44259/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44259/1//COMMIT_MSG@9 PS1, Line 9: Enable ASan in ramstage for all x86 platforms. This sounds like for x86 ASan in ramstage is enabled and active per default which is not the case. Please add here that in order to activate ASan in ramstage the right Kconfig switch needs to be enabled in menuconfig.
Hello build bot (Jenkins), Patrick Georgi, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44259
to look at the new patch set (#2).
Change subject: arch/x86: Select HAVE_ASAN_IN_RAMSTAGE ......................................................................
arch/x86: Select HAVE_ASAN_IN_RAMSTAGE
Enable ASan in ramstage if ASAN is selected in menuconfig for an x86 platform.
Change-Id: Id5b3dc18368a5da6bdc70c84527b95d1688dc19f Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com --- M src/arch/x86/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/44259/2
Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44259 )
Change subject: arch/x86: Select HAVE_ASAN_IN_RAMSTAGE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44259/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44259/1//COMMIT_MSG@9 PS1, Line 9: Enable ASan in ramstage for all x86 platforms.
This sounds like for x86 ASan in ramstage is enabled and active per default which is not the case. […]
Done
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44259 )
Change subject: arch/x86: Select HAVE_ASAN_IN_RAMSTAGE ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44259 )
Change subject: arch/x86: Select HAVE_ASAN_IN_RAMSTAGE ......................................................................
arch/x86: Select HAVE_ASAN_IN_RAMSTAGE
Enable ASan in ramstage if ASAN is selected in menuconfig for an x86 platform.
Change-Id: Id5b3dc18368a5da6bdc70c84527b95d1688dc19f Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44259 Reviewed-by: Werner Zeh werner.zeh@siemens.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 660ff2d..d906436 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -4,6 +4,7 @@ bool select PCI select RELOCATABLE_MODULES + select HAVE_ASAN_IN_RAMSTAGE
# stage selectors for x86
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44259 )
Change subject: arch/x86: Select HAVE_ASAN_IN_RAMSTAGE ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16029 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16028 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16027 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16026 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16025 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16031 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16030
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Harshit Sharma (Code Review)
-
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)