Change in ...coreboot[master]: payloads/tianocore: Don't fail on resetting boot logo

List overview All Threads
Download

newer

older

Change in ...coreboot[master]: fsp...

Matt DeVillier (Code Review)

31 Mar 2019 31 Mar '19

10:04 p.m.

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32133

Change subject: payloads/tianocore: Don't fail on resetting boot logo ......................................................................

payloads/tianocore: Don't fail on resetting boot logo

If using a commit/branch which doesn't use a boot logo, we don't want the build to fail unnecessarily

Test: build with upstream Tianocore commit hash, avoid failure after successful compilation.

Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M payloads/external/tianocore/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/32133/1

diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index 2c7439c..d5e26de 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -100,7 +100,7 @@ fi; \ build $(BUILD_STR); \ mv $(project_dir)/Build/CorebootPayloadPkg*/*/FV/UEFIPAYLOAD.fd $(project_dir)/Build/UEFIPAYLOAD.fd; \ - git checkout CorebootPayloadPkg/Logo/Logo.bmp > /dev/null 2>&1 + git checkout CorebootPayloadPkg/Logo/Logo.bmp > /dev/null 2>&1 | true

clean: test -d $(project_dir) && (cd $(project_dir); rm -rf Build; rm -f Conf/tools_def.txt) || exit 0

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Philipp Deppenwiese (Code Review)

1 Apr 1 Apr

8:10 a.m.

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32133 )

Change subject: payloads/tianocore: Don't fail on resetting boot logo ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Gerrit-Change-Number: 32133 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 01 Apr 2019 08:10:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

8:57 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32133 )

Change subject: payloads/tianocore: Don't fail on resetting boot logo ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Gerrit-Change-Number: 32133 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 01 Apr 2019 08:57:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2 Apr 2 Apr

10:23 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32133 )

Change subject: payloads/tianocore: Don't fail on resetting boot logo ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32133/1/payloads/external/tianocore/Makefile File payloads/external/tianocore/Makefile:

https://review.coreboot.org/#/c/32133/1/payloads/external/tianocore/Makefile... PS1, Line 103: | shouldn't that be || true?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Gerrit-Change-Number: 32133 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 02 Apr 2019 10:23:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Matt DeVillier (Code Review)

4:03 p.m.

Hello Angel Pons, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32133

to look at the new patch set (#2).

Change subject: payloads/tianocore: Don't fail on resetting boot logo ......................................................................

payloads/tianocore: Don't fail on resetting boot logo

If using a commit/branch which doesn't use a boot logo, we don't want the build to fail unnecessarily

Test: build with upstream Tianocore commit hash, avoid failure after successful compilation.

Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M payloads/external/tianocore/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/32133/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Gerrit-Change-Number: 32133 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Matt DeVillier (Code Review)

4:04 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32133 )

Change subject: payloads/tianocore: Don't fail on resetting boot logo ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32133/1/payloads/external/tianocore/Makefile File payloads/external/tianocore/Makefile:

https://review.coreboot.org/#/c/32133/1/payloads/external/tianocore/Makefile... PS1, Line 103: |

...

shouldn't that be || true?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Gerrit-Change-Number: 32133 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Apr 2019 16:04:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:32 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32133 )

Change subject: payloads/tianocore: Don't fail on resetting boot logo ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Gerrit-Change-Number: 32133 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Apr 2019 16:32:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:32 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32133 )

Change subject: payloads/tianocore: Don't fail on resetting boot logo ......................................................................

payloads/tianocore: Don't fail on resetting boot logo

If using a commit/branch which doesn't use a boot logo, we don't want the build to fail unnecessarily

Test: build with upstream Tianocore commit hash, avoid failure after successful compilation.

Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32133 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M payloads/external/tianocore/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index 2c7439c..f208e59 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -100,7 +100,7 @@ fi; \ build $(BUILD_STR); \ mv $(project_dir)/Build/CorebootPayloadPkg*/*/FV/UEFIPAYLOAD.fd $(project_dir)/Build/UEFIPAYLOAD.fd; \ - git checkout CorebootPayloadPkg/Logo/Logo.bmp > /dev/null 2>&1 + git checkout CorebootPayloadPkg/Logo/Logo.bmp > /dev/null 2>&1 || true

clean: test -d $(project_dir) && (cd $(project_dir); rm -rf Build; rm -f Conf/tools_def.txt) || exit 0

-- To view, visit https://review.coreboot.org/c/coreboot/+/32133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic41bacbb97926e9538f434aecc0f0eebc5f6326f Gerrit-Change-Number: 32133 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1859

days inactive

1861

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Matt DeVillier (Code Review)
Patrick Georgi (Code Review)
Philipp Deppenwiese (Code Review)