Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36579 )
Change subject: mb/*/*: Use sb/intel/common/acpi/platform.asl ......................................................................
mb/*/*: Use sb/intel/common/acpi/platform.asl
Change-Id: Ifc0799d26394a525d764fb4ffc096b48060ee22f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- D src/mainboard/asrock/g41c-gs/acpi/platform.asl M src/mainboard/asrock/g41c-gs/dsdt.asl D src/mainboard/asus/p5qpl-am/acpi/platform.asl M src/mainboard/asus/p5qpl-am/dsdt.asl D src/mainboard/foxconn/d41s/acpi/platform.asl M src/mainboard/foxconn/d41s/dsdt.asl D src/mainboard/foxconn/g41s-k/acpi/platform.asl M src/mainboard/foxconn/g41s-k/dsdt.asl D src/mainboard/gigabyte/ga-g41m-es2l/acpi/platform.asl D src/mainboard/intel/d510mo/acpi/platform.asl M src/mainboard/intel/d510mo/dsdt.asl D src/mainboard/intel/dg41wv/acpi/platform.asl M src/mainboard/intel/dg41wv/dsdt.asl D src/mainboard/lenovo/thinkcentre_a58/acpi/platform.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl 15 files changed, 7 insertions(+), 231 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/36579/1
diff --git a/src/mainboard/asrock/g41c-gs/acpi/platform.asl b/src/mainboard/asrock/g41c-gs/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/asrock/g41c-gs/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/asrock/g41c-gs/dsdt.asl b/src/mainboard/asrock/g41c-gs/dsdt.asl index 002dfca..18d6def 100644 --- a/src/mainboard/asrock/g41c-gs/dsdt.asl +++ b/src/mainboard/asrock/g41c-gs/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) { diff --git a/src/mainboard/asus/p5qpl-am/acpi/platform.asl b/src/mainboard/asus/p5qpl-am/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/asus/p5qpl-am/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/asus/p5qpl-am/dsdt.asl b/src/mainboard/asus/p5qpl-am/dsdt.asl index 002dfca..18d6def 100644 --- a/src/mainboard/asus/p5qpl-am/dsdt.asl +++ b/src/mainboard/asus/p5qpl-am/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) { diff --git a/src/mainboard/foxconn/d41s/acpi/platform.asl b/src/mainboard/foxconn/d41s/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/foxconn/d41s/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/foxconn/d41s/dsdt.asl b/src/mainboard/foxconn/d41s/dsdt.asl index 8dc1194..d33b523 100644 --- a/src/mainboard/foxconn/d41s/dsdt.asl +++ b/src/mainboard/foxconn/d41s/dsdt.asl @@ -24,7 +24,7 @@ 0x20090419 // OEM revision ) { - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
#include <cpu/intel/speedstep/acpi/cpu.asl> diff --git a/src/mainboard/foxconn/g41s-k/acpi/platform.asl b/src/mainboard/foxconn/g41s-k/acpi/platform.asl deleted file mode 100644 index bda0df7..0000000 --- a/src/mainboard/foxconn/g41s-k/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/foxconn/g41s-k/dsdt.asl b/src/mainboard/foxconn/g41s-k/dsdt.asl index 002dfca..18d6def 100644 --- a/src/mainboard/foxconn/g41s-k/dsdt.asl +++ b/src/mainboard/foxconn/g41s-k/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) { diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/acpi/platform.asl b/src/mainboard/gigabyte/ga-g41m-es2l/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/gigabyte/ga-g41m-es2l/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/intel/d510mo/acpi/platform.asl b/src/mainboard/intel/d510mo/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/intel/d510mo/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/intel/d510mo/dsdt.asl b/src/mainboard/intel/d510mo/dsdt.asl index 8dc1194..d33b523 100644 --- a/src/mainboard/intel/d510mo/dsdt.asl +++ b/src/mainboard/intel/d510mo/dsdt.asl @@ -24,7 +24,7 @@ 0x20090419 // OEM revision ) { - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
#include <cpu/intel/speedstep/acpi/cpu.asl> diff --git a/src/mainboard/intel/dg41wv/acpi/platform.asl b/src/mainboard/intel/dg41wv/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/intel/dg41wv/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/intel/dg41wv/dsdt.asl b/src/mainboard/intel/dg41wv/dsdt.asl index 002dfca..18d6def 100644 --- a/src/mainboard/intel/dg41wv/dsdt.asl +++ b/src/mainboard/intel/dg41wv/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) { diff --git a/src/mainboard/lenovo/thinkcentre_a58/acpi/platform.asl b/src/mainboard/lenovo/thinkcentre_a58/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/lenovo/thinkcentre_a58/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl b/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl index 002dfca..18d6def 100644 --- a/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl +++ b/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) {
Hello Alexander Couzens, Patrick Rudolph, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36579
to look at the new patch set (#3).
Change subject: mb/*/*{i82801gx}: Use sb/intel/common/acpi/platform.asl ......................................................................
mb/*/*{i82801gx}: Use sb/intel/common/acpi/platform.asl
Change-Id: Ifc0799d26394a525d764fb4ffc096b48060ee22f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- D src/mainboard/asrock/g41c-gs/acpi/platform.asl M src/mainboard/asrock/g41c-gs/dsdt.asl D src/mainboard/asus/p5qpl-am/acpi/platform.asl M src/mainboard/asus/p5qpl-am/dsdt.asl D src/mainboard/foxconn/d41s/acpi/platform.asl M src/mainboard/foxconn/d41s/dsdt.asl D src/mainboard/foxconn/g41s-k/acpi/platform.asl M src/mainboard/foxconn/g41s-k/dsdt.asl D src/mainboard/gigabyte/ga-g41m-es2l/acpi/platform.asl M src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl D src/mainboard/intel/d510mo/acpi/platform.asl M src/mainboard/intel/d510mo/dsdt.asl D src/mainboard/intel/dg41wv/acpi/platform.asl M src/mainboard/intel/dg41wv/dsdt.asl D src/mainboard/lenovo/thinkcentre_a58/acpi/platform.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl 16 files changed, 8 insertions(+), 232 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/36579/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36579 )
Change subject: mb/*/*{i82801gx}: Use sb/intel/common/acpi/platform.asl ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36579 )
Change subject: mb/*/*{i82801gx}: Use sb/intel/common/acpi/platform.asl ......................................................................
mb/*/*{i82801gx}: Use sb/intel/common/acpi/platform.asl
Change-Id: Ifc0799d26394a525d764fb4ffc096b48060ee22f Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36579 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- D src/mainboard/asrock/g41c-gs/acpi/platform.asl M src/mainboard/asrock/g41c-gs/dsdt.asl D src/mainboard/asus/p5qpl-am/acpi/platform.asl M src/mainboard/asus/p5qpl-am/dsdt.asl D src/mainboard/foxconn/d41s/acpi/platform.asl M src/mainboard/foxconn/d41s/dsdt.asl D src/mainboard/foxconn/g41s-k/acpi/platform.asl M src/mainboard/foxconn/g41s-k/dsdt.asl D src/mainboard/gigabyte/ga-g41m-es2l/acpi/platform.asl M src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl D src/mainboard/intel/d510mo/acpi/platform.asl M src/mainboard/intel/d510mo/dsdt.asl D src/mainboard/intel/dg41wv/acpi/platform.asl M src/mainboard/intel/dg41wv/dsdt.asl D src/mainboard/lenovo/thinkcentre_a58/acpi/platform.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl 16 files changed, 8 insertions(+), 232 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/mainboard/asrock/g41c-gs/acpi/platform.asl b/src/mainboard/asrock/g41c-gs/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/asrock/g41c-gs/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/asrock/g41c-gs/dsdt.asl b/src/mainboard/asrock/g41c-gs/dsdt.asl index e0e3a3a..31e7c10 100644 --- a/src/mainboard/asrock/g41c-gs/dsdt.asl +++ b/src/mainboard/asrock/g41c-gs/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) { diff --git a/src/mainboard/asus/p5qpl-am/acpi/platform.asl b/src/mainboard/asus/p5qpl-am/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/asus/p5qpl-am/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/asus/p5qpl-am/dsdt.asl b/src/mainboard/asus/p5qpl-am/dsdt.asl index e0e3a3a..31e7c10 100644 --- a/src/mainboard/asus/p5qpl-am/dsdt.asl +++ b/src/mainboard/asus/p5qpl-am/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) { diff --git a/src/mainboard/foxconn/d41s/acpi/platform.asl b/src/mainboard/foxconn/d41s/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/foxconn/d41s/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/foxconn/d41s/dsdt.asl b/src/mainboard/foxconn/d41s/dsdt.asl index dc1dacc..e07ecc2 100644 --- a/src/mainboard/foxconn/d41s/dsdt.asl +++ b/src/mainboard/foxconn/d41s/dsdt.asl @@ -24,7 +24,7 @@ 0x20090419 // OEM revision ) { - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
#include <cpu/intel/speedstep/acpi/cpu.asl> diff --git a/src/mainboard/foxconn/g41s-k/acpi/platform.asl b/src/mainboard/foxconn/g41s-k/acpi/platform.asl deleted file mode 100644 index bda0df7..0000000 --- a/src/mainboard/foxconn/g41s-k/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/foxconn/g41s-k/dsdt.asl b/src/mainboard/foxconn/g41s-k/dsdt.asl index e0e3a3a..31e7c10 100644 --- a/src/mainboard/foxconn/g41s-k/dsdt.asl +++ b/src/mainboard/foxconn/g41s-k/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) { diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/acpi/platform.asl b/src/mainboard/gigabyte/ga-g41m-es2l/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/gigabyte/ga-g41m-es2l/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl b/src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl index e0e3a3a..31e7c10 100644 --- a/src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl +++ b/src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) { diff --git a/src/mainboard/intel/d510mo/acpi/platform.asl b/src/mainboard/intel/d510mo/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/intel/d510mo/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/intel/d510mo/dsdt.asl b/src/mainboard/intel/d510mo/dsdt.asl index dc1dacc..e07ecc2 100644 --- a/src/mainboard/intel/d510mo/dsdt.asl +++ b/src/mainboard/intel/d510mo/dsdt.asl @@ -24,7 +24,7 @@ 0x20090419 // OEM revision ) { - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
#include <cpu/intel/speedstep/acpi/cpu.asl> diff --git a/src/mainboard/intel/dg41wv/acpi/platform.asl b/src/mainboard/intel/dg41wv/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/intel/dg41wv/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/intel/dg41wv/dsdt.asl b/src/mainboard/intel/dg41wv/dsdt.asl index e0e3a3a..31e7c10 100644 --- a/src/mainboard/intel/dg41wv/dsdt.asl +++ b/src/mainboard/intel/dg41wv/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) { diff --git a/src/mainboard/lenovo/thinkcentre_a58/acpi/platform.asl b/src/mainboard/lenovo/thinkcentre_a58/acpi/platform.asl deleted file mode 100644 index 6c92a4e..0000000 --- a/src/mainboard/lenovo/thinkcentre_a58/acpi/platform.asl +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Damien Zammit damien@zamaudio.com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Method(_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - Store(Arg0, PICM) -} - -/* SMI I/O Trap */ -Method(TRAP, 1, Serialized) -{ - Store (Arg0, SMIF) /* SMI Function */ - Store (0, TRP0) /* Generate trap */ - Return (SMIF) /* Return value of SMI handler */ -} diff --git a/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl b/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl index e0e3a3a..31e7c10 100644 --- a/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl +++ b/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl @@ -25,7 +25,7 @@ ) { // global NVS and variables - #include "acpi/platform.asl" + #include <southbridge/intel/common/acpi/platform.asl> #include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
Scope (_SB) {
-
Arthur Heymans (Code Review) -
Patrick Georgi (Code Review)