Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Nick Vaccaro, Subrata Banik.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85656?usp=email )
Change subject: mb/google/nissa/var/rull: Add G2 touchscreen to devicetree
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85656/comment/d0cb9446_2dc248f4?usp... :
PS1, Line 9: devicetre
devicetree
Done
File src/mainboard/google/brya/variants/rull/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85656/comment/60c9c4ee_dcfae41e?usp... :
PS1, Line 363: reset_delay_ms" = "120"
Can vendor improve this?
i will confirm it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85656?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0d68b8d09f2fd280dea17a0542243b88618b5fa1
Gerrit-Change-Number: 85656
Gerrit-PatchSet: 2
Gerrit-Owner: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 19 Dec 2024 03:23:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com